From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1X1d3p-0000wj-Bu
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 11:00:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1X1d3g-00042q-74
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 11:00:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1X1d3f-00042j-VH
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 10:59:52 -0400
Date: Mon, 30 Jun 2014 16:59:47 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140630145947.GD23599@noname.str.redhat.com>
References: <cover.1403723847.git.jcody@redhat.com>
	<b6c4f6e650630fe8ada64bb6f45c9f696e5a29c8.1403723847.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b6c4f6e650630fe8ada64bb6f45c9f696e5a29c8.1403723847.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 for 2.1 4/4] block: add QAPI command to
 allow live backing file change
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Am 25.06.2014 um 21:40 hat Jeff Cody geschrieben:
> This allows a user to make a live change to the backing file recorded in
> an open image.
> 
> The image file to modify can be specified 2 ways:
> 
> 1) image filename
> 2) image node-name
> 
> Note: this does not cause the backing file itself to be reopened; it
> merely changes the backing filename in the image file structure, and
> in internal BDS structures.
> 
> It is the responsibility of the user to pass a filename string that
> can be resolved when the image chain is reopened, and the filename
> string is not validated.
> 
> A good analogy for this command is that it is a live version of
> 'qemu-img rebase -u', with respect to changing the backing file string.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>

I'm not a huge fan of adding two different addressing modes to a new QMP
command. I consider using device_name/filename as deprecated and expect
that management tools use node-name for new commands.

Also there's still Eric's reply and Jeff's promise to update the patch
once blockers were sorted out for 2.1.

I'm leaning towards declaring this patch not ready.

Kevin