From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v4 07/13] ARM64 / ACPI: Introduce lowlevel suspend function Date: Mon, 30 Jun 2014 17:28:17 +0100 Message-ID: <20140630162817.GS28951@arm.com> References: <1403840976-7456-1-git-send-email-hanjun.guo@linaro.org> <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Hanjun Guo Cc: "Rafael J. Wysocki" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Bjorn Helgaas , "rric@kernel.org" , "grant.likely@linaro.org" , Sudeep Holla , Mark Rutland , Charles Garcia-Tobin , Lorenzo Pieralisi , "linaro-acpi@lists.linaro.org" , "graeme.gregory@linaro.org" List-Id: linux-acpi@vger.kernel.org On Fri, Jun 27, 2014 at 04:49:30AM +0100, Hanjun Guo wrote: > From: Graeme Gregory > > acpi_wakeup_address is used on x86 as the address bios jumps into > when machine wakes up from suspend. As arm64 does not have such a > bios this mechanism will be provided by other means. But the define > is still required inside the acpi core. Why not fix the place where it is used rather than defining a dummy pointer? > Introduce a null stub for acpi_suspend_lowlevel as this is also > required by core. This will be filled in when standards are > defined for arm64 ACPI global power states. I assume acpi_suspend_lowlevel would be just a dummy definition but it will have some use when the standard allows. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755478AbaF3Q2b (ORCPT ); Mon, 30 Jun 2014 12:28:31 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:20925 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754697AbaF3Q22 (ORCPT ); Mon, 30 Jun 2014 12:28:28 -0400 Date: Mon, 30 Jun 2014 17:28:17 +0100 From: Catalin Marinas To: Hanjun Guo Cc: "Rafael J. Wysocki" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Bjorn Helgaas , "rric@kernel.org" , "grant.likely@linaro.org" , Sudeep Holla , Mark Rutland , Charles Garcia-Tobin , Lorenzo Pieralisi , "linaro-acpi@lists.linaro.org" , "graeme.gregory@linaro.org" Subject: Re: [PATCH v4 07/13] ARM64 / ACPI: Introduce lowlevel suspend function Message-ID: <20140630162817.GS28951@arm.com> References: <1403840976-7456-1-git-send-email-hanjun.guo@linaro.org> <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 27, 2014 at 04:49:30AM +0100, Hanjun Guo wrote: > From: Graeme Gregory > > acpi_wakeup_address is used on x86 as the address bios jumps into > when machine wakes up from suspend. As arm64 does not have such a > bios this mechanism will be provided by other means. But the define > is still required inside the acpi core. Why not fix the place where it is used rather than defining a dummy pointer? > Introduce a null stub for acpi_suspend_lowlevel as this is also > required by core. This will be filled in when standards are > defined for arm64 ACPI global power states. I assume acpi_suspend_lowlevel would be just a dummy definition but it will have some use when the standard allows. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Mon, 30 Jun 2014 17:28:17 +0100 Subject: [PATCH v4 07/13] ARM64 / ACPI: Introduce lowlevel suspend function In-Reply-To: <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org> References: <1403840976-7456-1-git-send-email-hanjun.guo@linaro.org> <1403840976-7456-8-git-send-email-hanjun.guo@linaro.org> Message-ID: <20140630162817.GS28951@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 27, 2014 at 04:49:30AM +0100, Hanjun Guo wrote: > From: Graeme Gregory > > acpi_wakeup_address is used on x86 as the address bios jumps into > when machine wakes up from suspend. As arm64 does not have such a > bios this mechanism will be provided by other means. But the define > is still required inside the acpi core. Why not fix the place where it is used rather than defining a dummy pointer? > Introduce a null stub for acpi_suspend_lowlevel as this is also > required by core. This will be filled in when standards are > defined for arm64 ACPI global power states. I assume acpi_suspend_lowlevel would be just a dummy definition but it will have some use when the standard allows. -- Catalin