From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1tIa-0004fq-8Y for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:20:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1tIU-00032Z-3L for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:20:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1tIQ-00031v-Aj for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:20:14 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s618K885017102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 1 Jul 2014 04:20:09 -0400 Date: Tue, 1 Jul 2014 10:20:06 +0200 From: Kevin Wolf Message-ID: <20140701082006.GC4587@noname.str.redhat.com> References: <1404201136-30412-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404201136-30412-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 for 2.1 4/4] block: add QAPI command to allow live backing file change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Jeff Cody , qemu-devel@nongnu.org Am 01.07.2014 um 09:52 hat Stefan Hajnoczi geschrieben: > From: Jeff Cody > > This allows a user to make a live change to the backing file recorded in > an open image. > > The image file to modify can be specified 2 ways: > > 1) image filename > 2) image node-name > > Note: this does not cause the backing file itself to be reopened; it > merely changes the backing filename in the image file structure, and > in internal BDS structures. > > It is the responsibility of the user to pass a filename string that > can be resolved when the image chain is reopened, and the filename > string is not validated. > > A good analogy for this command is that it is a live version of > 'qemu-img rebase -u', with respect to changing the backing file string. > > [Jeff is offline so I respun this patch in his absence. Dropped image > filename since using node-name is preferred and this is a new command. > No need to introduce the limitations of finding images by filename. > --Stefan] > > Reviewed-by: Eric Blake > Signed-off-by: Jeff Cody > Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf