On Tue, Jul 01, 2014 at 01:06:22PM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 01, 2014 at 12:55:26PM +0100, Mark Brown wrote: > > Even though we mostly use GPIO descriptors internally we still use > > gpio_request_one() to request so we need to pair that with gpio_free() to > > release the GPIO. > This doesn't explain the reason... I see the current GPIO code doing this: > void gpio_free(unsigned gpio) > { > gpiod_free(gpio_to_desc(gpio)); > } > EXPORT_SYMBOL_GPL(gpio_free); Huh, good point (though it still seems a bit neater to match up the request and release functions I guess). Linus?