From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1xLl-0002TF-MC for qemu-devel@nongnu.org; Tue, 01 Jul 2014 08:39:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1xLh-00037G-1j for qemu-devel@nongnu.org; Tue, 01 Jul 2014 08:39:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1xLg-00037A-QJ for qemu-devel@nongnu.org; Tue, 01 Jul 2014 08:39:48 -0400 Date: Tue, 1 Jul 2014 15:41:50 +0300 From: "Michael S. Tsirkin" Message-ID: <20140701124150.GA5487@redhat.com> References: <20140527120423.15172.36698.stgit@3820> <1404215552-12962-1-git-send-email-batuzovk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404215552-12962-1-git-send-email-batuzovk@ispras.ru> Subject: Re: [Qemu-devel] [PATCH] Handle G_IO_HUP in tcp_chr_read for tcp chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Batuzov Cc: Antonios Motakis , Nikita Belov , qemu-devel@nongnu.org, Nikolay Nikolaev On Tue, Jul 01, 2014 at 03:52:32PM +0400, Kirill Batuzov wrote: > Due to GLib limitations it is not possible to create several watches on one > channel on Windows hosts. See bug #338943 in GNOME bugzilla for details: > https://bugzilla.gnome.org/show_bug.cgi?id=338943 > > Handle G_IO_HUP in tcp_chr_read. It is already watched by corresponding watch. > Also remove the second watch with its handler. > > This reverts commit cdaa86a54b232572bba594bf87a7416e527e460c. > ("Add G_IO_HUP handler for socket chardev") but keeps its functionality. > > Cc: Antonios Motakis > Cc: Nikolay Nikolaev > Cc: Michael S. Tsirkin > Signed-off-by: Kirill Batuzov > Signed-off-by: Nikita Belov > --- Thanks, applied. No reason to put below after --: it's useful in commit log. > GLib limitation resulted in a bug on Windows host. Steps to reproduce: > > Start qemu: qemu-system-i386 -qmp tcp:127.0.0.1:4444:server:nowait > Connect with telnet: telnet 127.0.0.1 4444 > Try sending some data from telnet. > Expected result: answers from QEMU. > Observed result: no answers (actually tcp_chr_read is not called at all). > > --- > include/sysemu/char.h | 1 - > qemu-char.c | 27 ++++++--------------------- > 2 files changed, 6 insertions(+), 22 deletions(-) > > diff --git a/include/sysemu/char.h b/include/sysemu/char.h > index c8b15f9..0bbd631 100644 > --- a/include/sysemu/char.h > +++ b/include/sysemu/char.h > @@ -84,7 +84,6 @@ struct CharDriverState { > int avail_connections; > int is_mux; > guint fd_in_tag; > - guint fd_hup_tag; > QemuOpts *opts; > QTAILQ_ENTRY(CharDriverState) next; > }; > diff --git a/qemu-char.c b/qemu-char.c > index 51917de..22a9777 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2673,6 +2673,12 @@ static gboolean tcp_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque) > uint8_t buf[READ_BUF_LEN]; > int len, size; > > + if (cond & G_IO_HUP) { > + /* connection closed */ > + tcp_chr_disconnect(chr); > + return TRUE; > + } > + > if (!s->connected || s->max_size <= 0) { > return TRUE; > } > @@ -2724,25 +2730,6 @@ CharDriverState *qemu_chr_open_eventfd(int eventfd) > } > #endif > > -static gboolean tcp_chr_chan_close(GIOChannel *channel, GIOCondition cond, > - void *opaque) > -{ > - CharDriverState *chr = opaque; > - > - if (cond != G_IO_HUP) { > - return FALSE; > - } > - > - /* connection closed */ > - tcp_chr_disconnect(chr); > - if (chr->fd_hup_tag) { > - g_source_remove(chr->fd_hup_tag); > - chr->fd_hup_tag = 0; > - } > - > - return TRUE; > -} > - > static void tcp_chr_connect(void *opaque) > { > CharDriverState *chr = opaque; > @@ -2752,8 +2739,6 @@ static void tcp_chr_connect(void *opaque) > if (s->chan) { > chr->fd_in_tag = io_add_watch_poll(s->chan, tcp_chr_read_poll, > tcp_chr_read, chr); > - chr->fd_hup_tag = g_io_add_watch(s->chan, G_IO_HUP, tcp_chr_chan_close, > - chr); > } > qemu_chr_be_generic_open(chr); > } > -- > 1.7.10.4