From: Lee Jones <lee.jones@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: sbkim73@samsung.com, sameo@linux.intel.com, broonie@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org,
Jonghwa Lee <jonghwa3.lee@samsung.com>
Subject: Re: [PATCHv8 2/4] regulator: s2mps11: Add support S2MPU02 regulator device
Date: Tue, 1 Jul 2014 15:02:26 +0100 [thread overview]
Message-ID: <20140701140226.GJ27971@lee--X1> (raw)
In-Reply-To: <1403680487-12141-3-git-send-email-cw00.choi@samsung.com>
On Wed, 25 Jun 2014, Chanwoo Choi wrote:
> This patch add S2MPU02 regulator device to existing S2MPS11 device driver
> because of little difference between S2MPS1x and S2MPU02. The S2MPU02
> regulator device includes LDO[1-28] and BUCK[1-7].
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> [Add missing linear_min_sel of S2MPU02 LDO regulators by Jonghwa Lee]
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Acked-by: Mark Brown <broonie@linaro.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/sec-core.c | 25 ++++
> drivers/regulator/s2mps11.c | 321 +++++++++++++++++++++++++++++++++++++++++--
Why are these change munged into one patch? Shouldn't the MFD changes
really be in patch 1?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-01 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 7:14 [PATCHv8 0/4] mfd: sec-core: Add support S2MPU02 PMIC device Chanwoo Choi
2014-06-25 7:14 ` [PATCHv8 1/4] mfd: sec-core: Add support for S2MPU02 device Chanwoo Choi
2014-07-01 14:00 ` Lee Jones
2014-06-25 7:14 ` [PATCHv8 2/4] regulator: s2mps11: Add support S2MPU02 regulator device Chanwoo Choi
2014-07-01 14:02 ` Lee Jones [this message]
2014-06-25 7:14 ` [PATCHv8 3/4] dt-bindings: mfd: s2mps11: Add support S2MPU02 PMIC Chanwoo Choi
2014-06-25 7:14 ` [PATCHv8 4/4] mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption Chanwoo Choi
2014-07-01 14:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701140226.GJ27971@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.