From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: pin OABUFFER to GGTT
Date: Tue, 1 Jul 2014 17:51:49 +0100
Message-ID: <20140701165149.GB7371@nuc-i3427.alporthouse.com>
References: <92648605EABDA246B775AAB04C95A7A3137EB4F3@IRSMSX103.ger.corp.intel.com>
 <20140701163017.GA7371@nuc-i3427.alporthouse.com>
 <92648605EABDA246B775AAB04C95A7A3137EB523@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
 by gabe.freedesktop.org (Postfix) with ESMTP id AB0E66E151
 for <Intel-gfx@lists.freedesktop.org>; Tue,  1 Jul 2014 09:52:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <92648605EABDA246B775AAB04C95A7A3137EB523@IRSMSX103.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Mateo Lozano, Oscar" <oscar.mateo@intel.com>
Cc: "Intel-gfx@lists.freedesktop.org" <Intel-gfx@lists.freedesktop.org>, "Madajczak, Tomasz" <Tomasz.Madajczak@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jul 01, 2014 at 04:34:48PM +0000, Mateo Lozano, Oscar wrote:
> > -----Original Message-----
> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > Sent: Tuesday, July 01, 2014 5:30 PM
> > To: Mateo Lozano, Oscar
> > Cc: Intel-gfx@lists.freedesktop.org; Madajczak, Tomasz
> > Subject: Re: [Intel-gfx] pin OABUFFER to GGTT
> > =

> > On Tue, Jul 01, 2014 at 04:24:56PM +0000, Mateo Lozano, Oscar wrote:
> > > Submitting again (this time copying the mailing list correctly):
> > >
> > > The bo_pin ioctl has been discarded in GEN6+ with this patch:
> > >
> > > =A0=A0=A0 drm/i915: Reject the pin ioctl on gen6+
> > >
> > > =A0=A0=A0=A0Especially with ppgtt this kinda stopped making sense. An=
d if we
> > > =A0=A0=A0 indeed need this to hack around an issue, we need something=
 that also
> > > =A0=A0=A0 works for non-root.
> > >
> > > =A0=A0=A0=A0Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch
> > >
> > > The thing is, the performance team used this call to pin the OABUFFER=
 to
> > GGTT and then mapping it to userspace. This OABUFFER cannot be in PPGTT
> > because: "When each context has its own Per Process GTT, this field sho=
uld
> > be always set to GGTT." (BSpec dixit).
> > >
> > > Can we re-enable it? or should we find an alternative for this case?
> > =

> > EXEC_OBJECT_NEEDS_GTT?
> > -Chris
> =

> The object (AFAICT, please Tomasz correct me if I am wrong) is not really=
 used inside any batchbuffer.

Then what's the issue? If you only use it as via a global gtt mapping it
only exists in the ggtt.

> Also:
> =

> 		if (exec[i].flags & EXEC_OBJECT_NEEDS_GTT &&
> 		    USES_FULL_PPGTT(vm->dev)) {
> 			ret =3D -EINVAL;
> 			goto err;
> 		}
> =


Yeah, that's just full-ppgtt not quite being ready yet.
-Chris

-- =

Chris Wilson, Intel Open Source Technology Centre