From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755645AbaGDNnH (ORCPT ); Fri, 4 Jul 2014 09:43:07 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:56419 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbaGDNnG (ORCPT ); Fri, 4 Jul 2014 09:43:06 -0400 Date: Fri, 4 Jul 2014 15:42:57 +0200 From: Thierry Reding To: Laura Abbott Cc: Will Deacon , Catalin Marinas , David Riley , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ritesh Harjain , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv4 4/5] arm: use genalloc for the atomic pool Message-ID: <20140704134254.GA4142@ulmo> References: <1404324218-4743-1-git-send-email-lauraa@codeaurora.org> <1404324218-4743-5-git-send-email-lauraa@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <1404324218-4743-5-git-send-email-lauraa@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 02, 2014 at 11:03:37AM -0700, Laura Abbott wrote: [...] > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c [...] > index f5190ac..02a1939 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include Includes should be sorted alphabetically. I realize that's not the case for this particular file, but the downside of that is that your patch no longer applies cleanly on top of linux-next because some other patch did add linux/cma.h at the same location. > static int __init early_coherent_pool(char *p) > { > - atomic_pool.size =3D memparse(p, &p); > + atomic_pool_size =3D memparse(p, &p); > return 0; > } > early_param("coherent_pool", early_coherent_pool); > =20 > + There's a gratuituous blank line her. I also need the below hunk on top of you patch to make this compile on ARM. Thierry diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index b323032f0850..460aaf965a87 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -1250,11 +1250,13 @@ static int __iommu_remove_mapping(struct device *de= v, dma_addr_t iova, size_t si =20 static struct page **__atomic_get_pages(void *addr) { - struct dma_pool *pool =3D &atomic_pool; - struct page **pages =3D pool->pages; - int offs =3D (addr - pool->vaddr) >> PAGE_SHIFT; + struct page *page; + phys_addr_t phys; + + phys =3D gen_pool_virt_to_phys(atomic_pool, (unsigned long)addr); + page =3D phys_to_page(phys); =20 - return pages + offs; + return (struct page **)page; } =20 static struct page **__iommu_get_pages(void *cpu_addr, struct dma_attrs *a= ttrs) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index a2487f12b2fc..764f53565958 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -441,7 +441,6 @@ remove_mapping: dma_common_free_remap(addr, atomic_pool_size, VM_USERMAP); destroy_genpool: gen_pool_destroy(atomic_pool); - atomic_pool =3D=3D NULL; free_page: if (!dma_release_from_contiguous(NULL, page, nr_pages)) __free_pages(page, get_order(atomic_pool_size)); --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTtq9eAAoJEN0jrNd/PrOhpXMQAL0++4Vz+tGUrju08/GKR5AN vqM3c6pBzLxlwwBEfaSdzTy+xyy6exaYMp3vo67stXvIwLzaGvnn8GYKyAurpXtK ssiL2nW5EkV0GiYWZJcXbrKmOdZcBMEuhimKjdwKBSA8jnCNEWdLxEmldemjvJGj S9NM1i3MVTFlEoVd+EcYy5aURy51rrlNG4Kb4IY4Qcpjykax24gjFNMt37NihSE0 a75MQgyjMFveYpn8XPtQoPmjzu3NycRp9UbfD+/Z3+Y3zVuN+hsmkU75inTYA/44 +R01xMBxygFL6xTJtfqgW5obH3TkAyIWOkgBFuNM5o38F+7o0/nxp++Pd+2UGaYe GIPjZnibpei/PT+q7Z21J7BG4hf5Z/RpNzWWzAFq29B4Yw9wVPVKeBMIET9q+8s0 6HZV9wESozFawqLTH/qUnJG7iPGQzInwjKQjFmqT2xn/BHyg+wyZdqoGSTFAEm0B EqTM3iuGQKqdlTBoOwwLvdeZZpUB1mrULndi+Dq0tILiS3HS8VFaOzd745lb+6Nu BcQzxi4s7YwlhhMe5NXjwH/OB+rOM9aQk0GCwRv9iLBFV3xfTAZbri9UiqxfmjCc bfc5Cic2g739npdrQ2uuvfi42XVSTBK0mPLfs/6NTPCIUdcyK30uNOTmigs17tt+ ABfo1C2Wknj2COhzhGAu =bc4p -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Fri, 4 Jul 2014 15:42:57 +0200 Subject: [PATCHv4 4/5] arm: use genalloc for the atomic pool In-Reply-To: <1404324218-4743-5-git-send-email-lauraa@codeaurora.org> References: <1404324218-4743-1-git-send-email-lauraa@codeaurora.org> <1404324218-4743-5-git-send-email-lauraa@codeaurora.org> Message-ID: <20140704134254.GA4142@ulmo> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 02, 2014 at 11:03:37AM -0700, Laura Abbott wrote: [...] > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c [...] > index f5190ac..02a1939 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include Includes should be sorted alphabetically. I realize that's not the case for this particular file, but the downside of that is that your patch no longer applies cleanly on top of linux-next because some other patch did add linux/cma.h at the same location. > static int __init early_coherent_pool(char *p) > { > - atomic_pool.size = memparse(p, &p); > + atomic_pool_size = memparse(p, &p); > return 0; > } > early_param("coherent_pool", early_coherent_pool); > > + There's a gratuituous blank line her. I also need the below hunk on top of you patch to make this compile on ARM. Thierry diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index b323032f0850..460aaf965a87 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -1250,11 +1250,13 @@ static int __iommu_remove_mapping(struct device *dev, dma_addr_t iova, size_t si static struct page **__atomic_get_pages(void *addr) { - struct dma_pool *pool = &atomic_pool; - struct page **pages = pool->pages; - int offs = (addr - pool->vaddr) >> PAGE_SHIFT; + struct page *page; + phys_addr_t phys; + + phys = gen_pool_virt_to_phys(atomic_pool, (unsigned long)addr); + page = phys_to_page(phys); - return pages + offs; + return (struct page **)page; } static struct page **__iommu_get_pages(void *cpu_addr, struct dma_attrs *attrs) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index a2487f12b2fc..764f53565958 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -441,7 +441,6 @@ remove_mapping: dma_common_free_remap(addr, atomic_pool_size, VM_USERMAP); destroy_genpool: gen_pool_destroy(atomic_pool); - atomic_pool == NULL; free_page: if (!dma_release_from_contiguous(NULL, page, nr_pages)) __free_pages(page, get_order(atomic_pool_size)); -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: