From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Dietrich Subject: Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement Date: Sat, 5 Jul 2014 13:49:03 +0200 Message-ID: <20140705134903.89ec088a6b90e48be9c36f89@gmx.de> References: <20140704195746.GA4346@ThinkPad> <20140704205941.GA7406@jak-x230> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140704205941.GA7406@jak-x230> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Julian Andres Klode Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Pawel Lebioda , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, ac100@lists.launchpad.net List-Id: linux-tegra@vger.kernel.org On Fri, 4 Jul 2014 22:59:41 +0200 Julian Andres Klode wrote: > On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote: > > Hi, > > > > This patch fixes the following warning reported by checkpatch.pl: > > > > WARNING: else is not generally useful after a break or return > > #235: FILE: drivers/staging/nvec/nvec.c:235: > > > > Regards > > Pawel Lebioda > > > > Signed-off-by: Pawel Lebioda > > drivers/staging/nvec/nvec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Hi Pawel, > > Please format your patches correctly. There should be no > "Hi", no "Regards", etc. After the signed off should be a > dashed line. > > Use git format-patch to format patches and you can send > them using git-send-email. yes, this way you reduce some apply-burdon from Greg. Ideally, you would combine all patches (one patch per checkpatch warning) in a common thread like this: git-format-patch --cover-letter --thread -s This way you could add some comments (if any) to the cover letter and just keep the plain checkpatch message in the other patches. This has also the advantage that the maintainers only have to ack the "cover letter". Marc -- Marc Dietrich From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754959AbaGELtW (ORCPT ); Sat, 5 Jul 2014 07:49:22 -0400 Received: from mout.gmx.net ([212.227.15.15]:51701 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbaGELtV (ORCPT ); Sat, 5 Jul 2014 07:49:21 -0400 Date: Sat, 5 Jul 2014 13:49:03 +0200 From: Marc Dietrich To: Julian Andres Klode Cc: Pawel Lebioda , Marc Dietrich , Greg Kroah-Hartman , ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement Message-Id: <20140705134903.89ec088a6b90e48be9c36f89@gmx.de> In-Reply-To: <20140704205941.GA7406@jak-x230> References: <20140704195746.GA4346@ThinkPad> <20140704205941.GA7406@jak-x230> X-Mailer: Sylpheed 3.4.0beta7 (GTK+ 2.24.23; arm-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ynenwDccR/26qxeY6+i0QhKVEOLnST8FIUvieFbXxOUjMBtdUYm sx9aKAddYy0iC/fZ3up0BCR5DdXRYG3HxDuVKVto2xSTh+7SmM8V6pDT5zkwd4shmWqLjId 0DM8OUe17gRjO278c/Gp61pF75gaHsXPOOHBw36VstZZNYY+V/76HHsRhFjqXb4zQC2z7cK AAWuQ1NaZoXI4icLn4seA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Jul 2014 22:59:41 +0200 Julian Andres Klode wrote: > On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote: > > Hi, > > > > This patch fixes the following warning reported by checkpatch.pl: > > > > WARNING: else is not generally useful after a break or return > > #235: FILE: drivers/staging/nvec/nvec.c:235: > > > > Regards > > Pawel Lebioda > > > > Signed-off-by: Pawel Lebioda > > drivers/staging/nvec/nvec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Hi Pawel, > > Please format your patches correctly. There should be no > "Hi", no "Regards", etc. After the signed off should be a > dashed line. > > Use git format-patch to format patches and you can send > them using git-send-email. yes, this way you reduce some apply-burdon from Greg. Ideally, you would combine all patches (one patch per checkpatch warning) in a common thread like this: git-format-patch --cover-letter --thread -s This way you could add some comments (if any) to the cover letter and just keep the plain checkpatch message in the other patches. This has also the advantage that the maintainers only have to ack the "cover letter". Marc -- Marc Dietrich