From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Restrict GPU boost to the RCS engine Date: Mon, 7 Jul 2014 11:05:00 +0200 Message-ID: <20140707090500.GK5821@phenom.ffwll.local> References: <1402565335-1759-1-git-send-email-chris@chris-wilson.co.uk> <53A96671.9060800@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id D0A416E297 for ; Mon, 7 Jul 2014 02:04:56 -0700 (PDT) Received: by mail-wi0-f173.google.com with SMTP id cc10so15432799wib.12 for ; Mon, 07 Jul 2014 02:04:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53A96671.9060800@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Deepak S Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 24, 2014 at 05:22:17PM +0530, Deepak S wrote: > Hi Chris/Daniel, > > The patch is helping in some of the side-effects due to gpu boost. I > still need to get more data. I will keep the thread updated. Ping. Might as well review it, too. -Daniel > > Thanks > Deepak > > On Thursday 12 June 2014 03:02 PM, Daniel Vetter wrote: > >Adding Deepak for testing, this hopefully alleviates the bad > >side-effects of the gpu booster he's seeing. > >-Daniel > > > >On Thu, Jun 12, 2014 at 11:28 AM, Chris Wilson wrote: > >>Make the assumption that media workloads are not as latency sensitive > >>for __wait_seqno, and that upclocking the GPU does not affect the BLT > >>engine. Under that assumption, we only wait to forcibly upclock the GPU > >>when we are stalling for results from the render pipeline. > >> > >>Signed-off-by: Chris Wilson > >>--- > >> drivers/gpu/drm/i915/i915_gem.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > >>index 5951618a6b08..242b595a0403 100644 > >>--- a/drivers/gpu/drm/i915/i915_gem.c > >>+++ b/drivers/gpu/drm/i915/i915_gem.c > >>@@ -1409,7 +1409,7 @@ static int __wait_seqno(struct intel_engine_cs *ring, u32 seqno, > >> > >> timeout_expire = timeout ? jiffies + timespec_to_jiffies_timeout(timeout) : 0; > >> > >>- if (INTEL_INFO(dev)->gen >= 6 && can_wait_boost(file_priv)) { > >>+ if (INTEL_INFO(dev)->gen >= 6 && ring->id == RCS && can_wait_boost(file_priv)) { > >> gen6_rps_boost(dev_priv); > >> if (file_priv) > >> mod_delayed_work(dev_priv->wq, > >>-- > >>2.0.0 > >> > >>_______________________________________________ > >>Intel-gfx mailing list > >>Intel-gfx@lists.freedesktop.org > >>http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch