From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH] Update sync-with-kernel to use installed kernel headers
Date: Mon, 7 Jul 2014 17:33:39 +0300 [thread overview]
Message-ID: <20140707143338.GA16460@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <5125392.NizmyE01KQ@avalon>
On Tue, Jul 01, 2014 at 06:24:26PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the review.
>
> On Tuesday 01 July 2014 17:30:38 Sakari Ailus wrote:
> > On Tue, Jun 03, 2014 at 12:40:19PM +0200, Laurent Pinchart wrote:
> > > diff --git a/Makefile.am b/Makefile.am
> > > index 11baed1..35d0030 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -12,31 +12,32 @@ EXTRA_DIST = include COPYING.libv4l README.libv4l
> > > README.lib-multi-threading>
> > > # custom targets
> > >
> > > sync-with-kernel:
> > > - @if [ ! -f $(KERNEL_DIR)/include/uapi/linux/videodev2.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/fb.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-controls.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-common.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-subdev.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/v4l2-mediabus.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/ivtv.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/frontend.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/dmx.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/audio.h -o \
> > > - ! -f $(KERNEL_DIR)/include/uapi/linux/dvb/video.h ]; then \
> > > + @if [ ! -f $(KERNEL_DIR)/usr/include/linux/videodev2.h -o \
> >
> > Shouldn't you use $(INSTALL_HDR_PATH) instead of $(KERNEL_DIR)/usr? If the
> > user sets that, the headers won't be installed under usr.
>
> INSTALL_HDR_PATH is only set when running make headers_install in the kernel
> tree, not when running make sync-with-kernel in the media built tree. If we
> want to support syncing with kernel headers installed elsewhere we should add
> a new option to this Makefile. I haven't done so as the need isn't clear to
> me.
Ok. Please then ignore my comment.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
prev parent reply other threads:[~2014-07-07 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 10:40 [PATCH] Update sync-with-kernel to use installed kernel headers Laurent Pinchart
2014-06-19 7:39 ` Laurent Pinchart
2014-07-01 14:30 ` Sakari Ailus
2014-07-01 16:24 ` Laurent Pinchart
2014-07-07 14:33 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707143338.GA16460@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.