From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 7 Jul 2014 12:47:02 -0400 Subject: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements In-Reply-To: <1404745842.30778.37.camel@kazak.uk.xensource.com> References: <1402306622-18485-1-git-send-email-hdegoede@redhat.com> <1404673937.4003.6.camel@hastur.hellion.org.uk> <53BA97A6.1000901@redhat.com> <1404745842.30778.37.camel@kazak.uk.xensource.com> Message-ID: <20140707164702.GN29202@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jul 07, 2014 at 04:10:42PM +0100, Ian Campbell wrote: > On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote: > > AFAIK we will never define both EMAC and GMAC for the same board, > > If we are sure of this (and I suspect this is the case, since IIRC they > share some pins) then I agree with your suggestion. > > > so IMHO a better fix would be to change this line: > > > > rc = sunxi_emac_initialize(bis); > > > > to: > > > > int rc = sunxi_emac_initialize(bis); That's not how we like things to look however when we can help it. Just toss a __maybe_unused in front of the declaration (and make sure we have included. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: