From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC 08/44] drm/i915: Added GPU scheduler config option Date: Mon, 7 Jul 2014 20:58:21 +0200 Message-ID: <20140707185821.GZ5821@phenom.ffwll.local> References: <1403803475-16337-1-git-send-email-John.C.Harrison@Intel.com> <1403803475-16337-9-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by gabe.freedesktop.org (Postfix) with ESMTP id AF0386E3F0 for ; Mon, 7 Jul 2014 11:58:11 -0700 (PDT) Received: by mail-we0-f180.google.com with SMTP id x48so4865365wes.39 for ; Mon, 07 Jul 2014 11:58:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1403803475-16337-9-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com Cc: Intel-GFX@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 26, 2014 at 06:23:59PM +0100, John.C.Harrison@Intel.com wrote: > From: John Harrison > > Added a Kconfig option for enabling/disabling the GPU scheduler. > --- > drivers/gpu/drm/i915/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 437e182..22a036b 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -81,3 +81,11 @@ config DRM_I915_UMS > enable this only if you have ancient versions of the DDX drivers. > > If in doubt, say "N". > + > +config DRM_I915_SCHEDULER > + bool "Enable GPU scheduler on Intel hardware" > + depends on DRM_I915 > + default y > + help > + Choose this option to enable GPU task scheduling for improved > + performance and efficiency. NACK. We ship one driver in one well tested config, everything else is a nightmare. There's very few exceptions (currently MMU_NOTIFIER and optional FBDEV support which have some really good reasons attached to them). And I'm still grumpy about the MMU_NOTIFIER one ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch