From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbaGGXP0 (ORCPT ); Mon, 7 Jul 2014 19:15:26 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49006 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbaGGXPY (ORCPT ); Mon, 7 Jul 2014 19:15:24 -0400 X-Sasl-enc: kz8bOGhdE5EOCX+83IBdvwM0tg36g3gacvz13/kpNtJn 1404774923 Date: Mon, 7 Jul 2014 16:19:45 -0700 From: Greg KH To: Andrew Morton Cc: David Rientjes , Sasha Levin , stable@vger.kernel.org, Al Viro , Jan Kara , Dave Jones , Heiko Carstens , Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [stable] please do not merge 058504edd026 (was Re: fs: use after free in /proc/pid/mountinfo) Message-ID: <20140707231945.GB4323@kroah.com> References: <53B3F331.7090204@oracle.com> <53B4CAB8.5070407@oracle.com> <53B6C051.2060704@oracle.com> <20140707230542.GJ11171@kroah.com> <20140707160627.dd260c98d20ce68f4668797a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140707160627.dd260c98d20ce68f4668797a@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 07, 2014 at 04:06:27PM -0700, Andrew Morton wrote: > On Mon, 7 Jul 2014 16:05:42 -0700 Greg KH wrote: > > > On Fri, Jul 04, 2014 at 03:35:54PM -0700, David Rientjes wrote: > > > On Fri, 4 Jul 2014, Sasha Levin wrote: > > > > > > > > Does this now reproduce on Linus's tree? If so, does reverting commit > > > > > 058504edd026 ("fs/seq_file: fallback to vmalloc allocation") prevent this > > > > > issue? > > > > > > > > > > This is a use-after-free since the poison value is 0x6b and I'm presuming > > > > > that your /proc/self/mountinfo may be larger than PAGE_SIZE in your > > > > > testing environment. > > > > > > > > > > > > > Good call, reverting that patch made both issues go away. > > > > > > > > > > Thanks for checking, Sasha. > > > > > > Stable maintainers, please do not merge commit 058504edd026 ("fs/seq_file: > > > fallback to vmalloc allocation") that is annotated with a cc for > > > stable@vger.kernel.org in Linus's tree into stable kernels. > > > > > > Although we're at 3.16-rc3, I'm hoping that we can get a fix for the > > > use-after-free in the next couple days before asking for a revert. Sasha > > > confirms[*] this commit causes the bug. > > > > I should also drop "Subject: /proc/stat: convert to single_open_size()" > > from the -stable tree, right? > > > > That would be best. Ok, now dropped, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: please do not merge 058504edd026 (was Re: fs: use after free in /proc/pid/mountinfo) Date: Mon, 7 Jul 2014 16:19:45 -0700 Message-ID: <20140707231945.GB4323@kroah.com> References: <53B3F331.7090204@oracle.com> <53B4CAB8.5070407@oracle.com> <53B6C051.2060704@oracle.com> <20140707230542.GJ11171@kroah.com> <20140707160627.dd260c98d20ce68f4668797a@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Rientjes , Sasha Levin , stable@vger.kernel.org, Al Viro , Jan Kara , Dave Jones , Heiko Carstens , Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20140707160627.dd260c98d20ce68f4668797a@linux-foundation.org> Sender: stable-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jul 07, 2014 at 04:06:27PM -0700, Andrew Morton wrote: > On Mon, 7 Jul 2014 16:05:42 -0700 Greg KH wrote: > > > On Fri, Jul 04, 2014 at 03:35:54PM -0700, David Rientjes wrote: > > > On Fri, 4 Jul 2014, Sasha Levin wrote: > > > > > > > > Does this now reproduce on Linus's tree? If so, does reverting commit > > > > > 058504edd026 ("fs/seq_file: fallback to vmalloc allocation") prevent this > > > > > issue? > > > > > > > > > > This is a use-after-free since the poison value is 0x6b and I'm presuming > > > > > that your /proc/self/mountinfo may be larger than PAGE_SIZE in your > > > > > testing environment. > > > > > > > > > > > > > Good call, reverting that patch made both issues go away. > > > > > > > > > > Thanks for checking, Sasha. > > > > > > Stable maintainers, please do not merge commit 058504edd026 ("fs/seq_file: > > > fallback to vmalloc allocation") that is annotated with a cc for > > > stable@vger.kernel.org in Linus's tree into stable kernels. > > > > > > Although we're at 3.16-rc3, I'm hoping that we can get a fix for the > > > use-after-free in the next couple days before asking for a revert. Sasha > > > confirms[*] this commit causes the bug. > > > > I should also drop "Subject: /proc/stat: convert to single_open_size()" > > from the -stable tree, right? > > > > That would be best. Ok, now dropped, thanks. greg k-h