All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Erik Arfvidson <erik.arfvidson@unisys.com>
Cc: sparmaintainer@unisys.com,
	driverdev-devel@linuxdriverproject.org,
	benjamin.romer@unisys.com
Subject: Re: [PATCH 2/2] staging: unisys: added virtpci info entry
Date: Tue, 8 Jul 2014 10:34:57 -0700	[thread overview]
Message-ID: <20140708173457.GA6061@kroah.com> (raw)
In-Reply-To: <1404840091-12058-2-git-send-email-erik.arfvidson@unisys.com>

On Tue, Jul 08, 2014 at 01:21:31PM -0400, Erik Arfvidson wrote:
> -
> +	/*debug_fs file and direcroty removal*/
> +		debugfs_remove(info_debugfs_entry);
> +		debugfs_remove(virtpci_debugfs_dir);

Odd indentation, comment style, and spelling typos :(

Also, you can just remove the directory recursivly, no need to save, and
then remove, the individual files.

thanks,

greg k-h

  reply	other threads:[~2014-07-08 17:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 17:21 [PATCH 1/2] staging: unisys: remove all proc entries from virtpci Erik Arfvidson
2014-07-08 17:21 ` [PATCH 2/2] staging: unisys: added virtpci info entry Erik Arfvidson
2014-07-08 17:34   ` Greg KH [this message]
2014-07-08 17:52   ` Dan Carpenter
2014-07-08 19:22     ` Erik Arfvidson
2014-07-09 20:22 Erik Arfvidson
2014-07-09 20:40 ` Greg KH
2014-07-09 20:41 ` Greg KH
2014-07-10 14:34 Erik Arfvidson
2014-07-10 14:51 ` Greg KH
2014-07-11 13:00   ` Romer, Benjamin M
2014-07-11 13:29     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708173457.GA6061@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=benjamin.romer@unisys.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=erik.arfvidson@unisys.com \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.