From: Francois Romieu <romieu@fr.zoreil.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
nic_swsd@realtek.com
Subject: Re: [PATCH net] r8169: disable L23
Date: Tue, 8 Jul 2014 22:16:30 +0200 [thread overview]
Message-ID: <20140708201630.GA31885@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1394712342-15778-6-Taiwan-albertk@realtek.com>
Hayes Wang <hayeswang@realtek.com> :
> For RTL8411, RTL8111G, RTL8402, RTL8105, and RTL8106, the nic couldn't
> leave the power saving mode of L23 for certain situation. This causes
> the device lost for the system. Disable the L23 mode to avoid it.
Ok with the patch as it exactly addresses the required hw_start methods
to cover the aforementionned RTL8xyz range.
Can you elaborate what L23 is or should the commit message be reworded
as "Disable a (yet undocumented) power saving feature that randomly
causes RTL8411, RTL8111G, RTL8402, RTL8105, and RTL8106 devices to be
lost on some systems." ?
If nobody really understands what the bug is nor what the specific
circumstances that triggers it are, it would be nice to state it clearly.
If not there is plenty of room to improve the description before it
comes close to full disclosure.
--
Ueimor
next prev parent reply other threads:[~2014-07-08 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 8:26 [PATCH net] r8169: disable L23 Hayes Wang
2014-07-08 20:16 ` Francois Romieu [this message]
2014-07-09 6:36 ` Hayes Wang
2014-07-09 2:59 ` David Miller
2014-07-09 6:52 ` [PATCH net v2] " Hayes Wang
2014-07-09 22:09 ` Francois Romieu
2014-07-09 23:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708201630.GA31885@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.