From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 09 Jul 2014 08:50:35 +0000 Subject: Re: [PATCH] ARM: shmobile: Remove opps table check for cpufreq Message-Id: <20140709085035.GJ5656@verge.net.au> List-Id: References: <53AA8130.2020304@bp.renesas.com> <53AA8FEC.6050808@bp.renesas.com> In-Reply-To: <53AA8FEC.6050808@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wed, Jun 25, 2014 at 06:01:32PM +0900, Gaku Inami wrote: > (2014/06/25 17:04), Viresh Kumar wrote: > > On 25 June 2014 13:28, Gaku Inami wrote: > >> This patch is based on feedback from Viresh Kumar. > >> Since cpufreq-cpu0 driver has already check opp table, there is no > >> need to same check in mach-shmobile. > >> > >> Signed-off-by: Gaku Inami > >> --- > >> > >> Based on : renesas-devel-v3.16-rc2-20140623 > > I hope you have tested that this doesn't break it :) > > I have already tested this patch. > There was no problem to verify the following cases. > case1 : Normal case > case2 : Opps table is not exist > case3 : CONFIG_GENERIC_CPUFREQ_CPU0 is disabled Thanks, and sorry for letting this slip through the cracks. I have queued it up. > >> arch/arm/mach-shmobile/cpufreq.c | 16 +--------------- > >> 1 file changed, 1 insertion(+), 15 deletions(-) > >> > >> diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c > >> index e2c868f..8a24b2b 100644 > >> --- a/arch/arm/mach-shmobile/cpufreq.c > >> +++ b/arch/arm/mach-shmobile/cpufreq.c > >> @@ -8,24 +8,10 @@ > >> * for more details. > >> */ > >> > >> -#include > >> -#include > >> #include > >> > >> int __init shmobile_cpufreq_init(void) > >> { > >> - struct device_node *np; > >> - > >> - np = of_cpu_device_node_get(0); > >> - if (np = NULL) { > >> - pr_err("failed to find cpu0 node\n"); > >> - return 0; > >> - } > >> - > >> - if (of_get_property(np, "operating-points", NULL)) > >> - platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0); > >> - > >> - of_node_put(np); > >> - > >> + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0); > >> return 0; > >> } > > Now that there is nothing else in this file, do you really need a separate > > file for cpufreq? > > > > Acked-by: Viresh Kumar > > Thank you for your ack. I hope to leave this file. > In the future, I will add a fix that depends on Renesas-SoC to this file. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Wed, 9 Jul 2014 10:50:35 +0200 Subject: [PATCH] ARM: shmobile: Remove opps table check for cpufreq In-Reply-To: <53AA8FEC.6050808@bp.renesas.com> References: <53AA8130.2020304@bp.renesas.com> <53AA8FEC.6050808@bp.renesas.com> Message-ID: <20140709085035.GJ5656@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 25, 2014 at 06:01:32PM +0900, Gaku Inami wrote: > (2014/06/25 17:04), Viresh Kumar wrote: > > On 25 June 2014 13:28, Gaku Inami wrote: > >> This patch is based on feedback from Viresh Kumar. > >> Since cpufreq-cpu0 driver has already check opp table, there is no > >> need to same check in mach-shmobile. > >> > >> Signed-off-by: Gaku Inami > >> --- > >> > >> Based on : renesas-devel-v3.16-rc2-20140623 > > I hope you have tested that this doesn't break it :) > > I have already tested this patch. > There was no problem to verify the following cases. > case1 : Normal case > case2 : Opps table is not exist > case3 : CONFIG_GENERIC_CPUFREQ_CPU0 is disabled Thanks, and sorry for letting this slip through the cracks. I have queued it up. > >> arch/arm/mach-shmobile/cpufreq.c | 16 +--------------- > >> 1 file changed, 1 insertion(+), 15 deletions(-) > >> > >> diff --git a/arch/arm/mach-shmobile/cpufreq.c b/arch/arm/mach-shmobile/cpufreq.c > >> index e2c868f..8a24b2b 100644 > >> --- a/arch/arm/mach-shmobile/cpufreq.c > >> +++ b/arch/arm/mach-shmobile/cpufreq.c > >> @@ -8,24 +8,10 @@ > >> * for more details. > >> */ > >> > >> -#include > >> -#include > >> #include > >> > >> int __init shmobile_cpufreq_init(void) > >> { > >> - struct device_node *np; > >> - > >> - np = of_cpu_device_node_get(0); > >> - if (np == NULL) { > >> - pr_err("failed to find cpu0 node\n"); > >> - return 0; > >> - } > >> - > >> - if (of_get_property(np, "operating-points", NULL)) > >> - platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0); > >> - > >> - of_node_put(np); > >> - > >> + platform_device_register_simple("cpufreq-cpu0", -1, NULL, 0); > >> return 0; > >> } > > Now that there is nothing else in this file, do you really need a separate > > file for cpufreq? > > > > Acked-by: Viresh Kumar > > Thank you for your ack. I hope to leave this file. > In the future, I will add a fix that depends on Renesas-SoC to this file. >