Re: [PATCH V4 1/2] perf ignore LBR and extra_regs.

From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@intel.com
Cc: andi@firstfloor.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH V4 1/2] perf ignore LBR and extra_regs.
Date: Wed, 9 Jul 2014 16:16:31 +0200	[thread overview]
Message-ID: <20140709141631.GE9918@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1404838181-3911-1-git-send-email-kan.liang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Tue, Jul 08, 2014 at 09:49:40AM -0700, kan.liang@intel.com wrote:
> +/*
> + * Under certain circumstances, access certain MSR may cause #GP.
> + * The function tests if the input MSR can be safely accessed.
> + */
> +static inline bool check_msr(unsigned long msr)
> +{
> +	u64 value;
> +
> +	if (rdmsrl_safe(msr, &value) < 0)
> +		return false;
> +	if (wrmsrl_safe(msr, value) < 0)
> +		return false;
> +	return true;
> +}

What does this thing return after patch 2? does the write still fault or
will KVM silently take writes too?

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]