From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Thu, 10 Jul 2014 00:57:33 +0200 Subject: [U-Boot] [PATCH] catch wrong load address passed to fatload / ext2load In-Reply-To: <201407092307.56541.marex@denx.de> References: <20140709204257.GA28671@amd.pavel.ucw.cz> <201407092307.56541.marex@denx.de> Message-ID: <20140709225733.GA29453@amd.pavel.ucw.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed 2014-07-09 23:07:56, Marek Vasut wrote: > On Wednesday, July 09, 2014 at 10:42:57 PM, Pavel Machek wrote: > > If filename is passed instead of address to ext2load or fatload, > > u-boot silently accepts that, and uses 0 for load address and default > > filename from environment. That is confusing, display help instead. > > > > Signed-off-by: Pavel Machek > > The handling of simple_strtoul() in fs.c could use improvement like this in > general. Do you mind expanding this patch ? I'd prefer not to do that at this moment: I don't have working-enough u-boot and hate to do changes without testing. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html