All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: peter@hurleysoftware.com, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, sethb@digi.com,
	aaro.koskinen@iki.fi, sam@ravnborg.org,
	tsbogend@alpha.franken.de
Subject: Re: [PATCH 0/2] fixes for empty tx buffer breakage
Date: Thu, 10 Jul 2014 16:29:24 -0700	[thread overview]
Message-ID: <20140710232924.GA9954@kroah.com> (raw)
In-Reply-To: <20140710.161205.2079073830695357277.davem@davemloft.net>

On Thu, Jul 10, 2014 at 04:12:05PM -0700, David Miller wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date: Thu, 10 Jul 2014 16:14:32 -0700
> 
> > On Sun, Jul 06, 2014 at 11:29:51AM -0400, Peter Hurley wrote:
> >> Cc: Seth Bollinger <sethb@digi.com>
> >> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> >> Cc: Sam Ravnborg <sam@ravnborg.org>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> >> 
> >> Greg,
> >> 
> >> I completed the audit of serial drivers after reports that
> >> several Sun serial drivers were broken by
> >> commit 717f3bbab3c7628736ef738fdbf3d9a28578c26c,
> >> 'serial_core: Fix conditional start_tx on ring buffer not empty'.
> >> 
> >> I apologize for not submitting this sooner. The delay was due to
> >> an ongoing analysis of serial flow control prompted by Sam Ravnborg's
> >> question:
> >> 
> >> On 06/10/2014 03:24 PM, Sam Ravnborg wrote:
> >> > I also noticed the typical pattern is:
> >> > 
> >> >      if (uart_circ_empty(xmit) || uart_tx_stopped(port))
> >> > 
> >> > Should you use this pattern also in sunsab.c?
> >> 
> >> Unfortunately, that analysis revealed that tx flow control is
> >> largely SMP-unsafe, and it's fairly easy to corrupt the hardware
> >> state wrt. the tty flow control state.
> >> 
> >> I'm still working on the solutions to that; they're too
> >> extensive to submit for 3.16 anyway.
> > 
> > So these should go into 3.16-final?  Or 3.17?
> 
> Definitely 3.16, this regression is several releases old.

Ok, will queue it up, thanks.

gre gk-h

      reply	other threads:[~2014-07-10 23:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 20:59 Linux 3.15: SPARC serial console regression Aaro Koskinen
2014-06-09 20:59 ` Aaro Koskinen
2014-06-09 23:43 ` On 06/09/2014 04:59 PM, Aaro Koskinen wrote:> Hi, Peter Hurley
2014-06-09 23:43   ` Peter Hurley
2014-06-09 23:48 ` FW: Linux 3.15: SPARC serial console regression Peter Hurley
2014-06-09 23:48   ` Peter Hurley
2014-06-10 18:53   ` Aaro Koskinen
2014-06-10 18:53     ` Aaro Koskinen
2014-06-10 19:24   ` Sam Ravnborg
2014-06-10 19:24     ` Sam Ravnborg
2014-06-10 21:20     ` Peter Hurley
2014-06-10 21:20       ` Peter Hurley
2014-06-15 18:56       ` Sam Ravnborg
2014-06-15 18:56         ` Sam Ravnborg
2014-06-16 14:24         ` Thomas Bogendoerfer
2014-06-16 14:24           ` Thomas Bogendoerfer
2014-06-16 15:37         ` Peter Hurley
2014-06-16 15:37           ` Peter Hurley
2014-06-18  6:19         ` David Miller
2014-06-18  6:19           ` David Miller
2014-06-13 20:18   ` Linux 3.15: " Aaro Koskinen
2014-06-13 20:18     ` Aaro Koskinen
2014-07-06 15:29 ` [PATCH 0/2] fixes for empty tx buffer breakage Peter Hurley
2014-07-06 15:29   ` [PATCH 1/2] serial: Test for no tx data on tx restart Peter Hurley
2014-07-06 15:29   ` [PATCH 2/2] serial: arc_uart: Use uart_circ_empty() for open-coded comparison Peter Hurley
2014-07-10 23:14   ` [PATCH 0/2] fixes for empty tx buffer breakage Greg Kroah-Hartman
2014-07-10 23:12     ` David Miller
2014-07-10 23:29       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710232924.GA9954@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=sam@ravnborg.org \
    --cc=sethb@digi.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.