From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices Date: Wed, 16 Jul 2014 08:35:30 -0400 Message-ID: <20140716123530.GA22437@localhost.localdomain> References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com> <9007827.iVFoEikAOq@xps13> <20140714134616.GC27848@tuxdriver.com> <5622385.bvoogjtUK7@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <5622385.bvoogjtUK7@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Tue, Jul 15, 2014 at 11:27:45PM +0200, Thomas Monjalon wrote: > 2014-07-14 09:46, John W. Linville: > > On Sat, Jul 12, 2014 at 12:34:46AM +0200, Thomas Monjalon wrote: > > > 2014-07-11 13:40, John W. Linville: > > > > Is there an example of code in DPDK that requires specific kernel > > > > versions? What is the preferred method for coding such dependencies? > > > > > > No there is no userspace code checking kernel version in DPDK. > > > Feel free to use what you think the best method. > > > Please keep in mind that checking version number is a maintenance > > > nightmare > > > because of backports (like RedHat do ;). > > Actually, I feel the need to correct this (I know you're being humorous, but just the same). You don't have a maintenence nightmare on your hands because RedHat backports kernel features, you have a nightmare maintenece situation on your hands because the DPDK uses kernel features that were never meant to be directly accessed outside of kernel space. Neil > > I suppose that it could be a configuration option? > > If there is no other way to configure kernel-dependent features, we can add > options. But I feel that relying on a macro (#ifdef) would be better if such > macro exist. > > -- > Thomas >