From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 16 Jul 2014 15:13:30 +0200 Subject: [U-Boot] socfpga: initialize MMC In-Reply-To: <20140716125238.CF3833804B5@gemini.denx.de> References: <20140716123422.GA8844@amd.pavel.ucw.cz> <20140716125238.CF3833804B5@gemini.denx.de> Message-ID: <20140716131330.A93E83804B5@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Pavel, In message <20140716125238.CF3833804B5@gemini.denx.de> I wrote: > > > + add_dwmci(host, host->bus_hz, host->bus_hz); > > Is there a free(host) anywhere? I think there is none, which raises the question why you use malloc() in the first place. Just use a struct on the stack. Also, please make sure to check the return code of add_dwmci() for errors, and handle these as needed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The light at the end of the tunnel is usually a "No Exit" sign.