From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 17 Jul 2014 14:01:20 +0200
Subject: [U-Boot] socfpga: initialize MMC
In-Reply-To: <1405594852.2088.8.camel@clsee-VirtualBox.altera.com>
References: <20140716123422.GA8844@amd.pavel.ucw.cz>
	<20140716125238.CF3833804B5@gemini.denx.de>
	<20140716131330.A93E83804B5@gemini.denx.de>
	<1405594852.2088.8.camel@clsee-VirtualBox.altera.com>
Message-ID: <20140717120120.125DC383374@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Chin Liang,

In message <1405594852.2088.8.camel@clsee-VirtualBox.altera.com> you wrote:
> 
> > > > +	add_dwmci(host, host->bus_hz, host->bus_hz);
> > > 
> > > Is there a free(host) anywhere?
> 
> Actually the host will be referred throughout the code execution when
> SDMMC access is required. Hence, we can only call the free when exit
> which deems not needed then.

I have to admit that I have hard times trying to understand the
concept of behind this code.

1) The new patches add  altera_dwmmc_init()  - but is this not
   basically a verbatim copy of  socfpga_dwmmc_init()  which is
   alreday in mainline?

   Except that the new patches use hardcoded constants (which is BAD)
   where the current mainline code uses #defines:

   altera_dwmmc_init():

	host->bus_hz = 400000;

   socfpga_dwmmc_init():

	host->bus_hz = CONFIG_SOCFPGA_DWMMC_BUS_HZ;

2) Is it really necessary to always and unconditionally initialyze
   the MMC subsystem, even in nobody will ever use any MMC commands in
   U-Boot?  The rule is that we only initialize hardwar when we
   actually use them inside of U-Boot, i. e. if any commands are
   executed that access such hardware?

   [Ok, this seems to be a generic problem, not specific you your
   patch set.]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The average woman would rather have beauty than brains,  because  the
average man can see better than he can think.