From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch] socfpga: fix clock manager register definition
Date: Sun, 20 Jul 2014 01:13:21 +0200 [thread overview]
Message-ID: <201407200113.21465.marex@denx.de> (raw)
In-Reply-To: <20140719221258.GA7405@amd.pavel.ucw.cz>
On Sunday, July 20, 2014 at 12:12:58 AM, Pavel Machek wrote:
> On Sun 2014-07-20 00:06:59, Marek Vasut wrote:
> > On Saturday, July 19, 2014 at 11:57:59 PM, Pavel Machek wrote:
> > > Structure defining clock manager hardware was wrong, leading to
> > > wrong registers being accessed and hang in MMC init.
> > >
> > > This fixes structure to match hardware.
> > >
> > > Signed-off-by: Pavel Machek <pavel@denx.de>
> > >
> > > diff --git a/arch/arm/cpu/armv7/socfpga/clock_manager.c
> > > b/arch/arm/cpu/armv7/socfpga/clock_manager.c index 23d697d..0228ac8
> > > 100644 --- a/arch/arm/cpu/armv7/socfpga/clock_manager.c
> > > +++ b/arch/arm/cpu/armv7/socfpga/clock_manager.c
> > > @@ -110,8 +110,8 @@ void cm_basic_init(const cm_config_t *cfg)
> > >
> > > * gatting off the rest of the periperal clocks.
> > > */
> > >
> > > writel(~CLKMGR_PERPLLGRP_EN_NANDCLK_MASK &
> > >
> > > - readl(&clock_manager_base->per_pll_en),
> > > - &clock_manager_base->per_pll_en);
> > > + readl(&clock_manager_base->per_pll.en),
> > > + &clock_manager_base->per_pll.en);
> >
> > clrbits_le32() please ... and please fix globally.
> > [...]
>
> But that's clearly something for separate patch, so I'd still like
> your ack on this one :-).
> Pavel
I cannot ACK a patch for hardware which I don't understand enough. Still, you're
already messing with the register layout, feel free to do a two-part patchset,
but please use the clrsetbits_le32() ...
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-07-19 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 21:57 [U-Boot] [patch] socfpga: fix clock manager register definition Pavel Machek
2014-07-19 22:06 ` Marek Vasut
2014-07-19 22:12 ` Pavel Machek
2014-07-19 23:13 ` Marek Vasut [this message]
2014-08-30 15:13 ` [U-Boot] " Tom Rini
2014-08-31 10:48 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201407200113.21465.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.