From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 21 Jul 2014 12:50:37 +0200
Subject: [U-Boot] socfpga: initialize MMC
In-Reply-To: <20140721102004.GA12896@amd.pavel.ucw.cz>
References: <20140716123422.GA8844@amd.pavel.ucw.cz>
	<20140716125238.CF3833804B5@gemini.denx.de>
	<20140721102004.GA12896@amd.pavel.ucw.cz>
Message-ID: <20140721105037.D9A353802AE@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Pavel,

In message <20140721102004.GA12896@amd.pavel.ucw.cz> you wrote:
> 
> > >  #define SOCFPGA_CLKMGR_ADDRESS 0xffd04000
> > >  #define SOCFPGA_RSTMGR_ADDRESS 0xffd05000
> > >  #define SOCFPGA_SYSMGR_ADDRESS 0xffd08000
> > > +#define SOCFPGA_SDMMC_ADDRESS 0xff704000
> > 
> > Please keep list sorted.
> 
> It was sorted by address before, so I'll keep it like that.

Yes, it was sorted by address, and 0xff704000 goes _before_
0xffd08000, not after.

> > > --- a/drivers/mmc/Makefile
> > > +++ b/drivers/mmc/Makefile
> > > @@ -28,6 +28,7 @@ obj-$(CONFIG_SPEAR_SDHCI) += spear_sdhci.o
> > >  obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o
> > >  obj-$(CONFIG_DWMMC) += dw_mmc.o
> > >  obj-$(CONFIG_EXYNOS_DWMMC) += exynos_dw_mmc.o
> > > +obj-$(CONFIG_ALTERA_DWMMC) += altera_dw_mmc.o
> > >  obj-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o
> > >  obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o
> > >  obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o
> > 
> > Ditto.  This should be a sorted list.
> 
> This was not sorted and I will not need to modify it in next patch
> version, so I'll leave this unfixed.

No, please clean up and fix it.

> > Is there a free(host) anywhere?
> 
> Dynamic allocation does not make much sense here, agreed. But as it is
> existing code, and there are bigger issues around, I'd prefer to leave
> it to someone else to clean it up...

I tend to disagree.  If we do not fix the problems as we see them, and
when we are working on the code anyway, they will never get fixed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When the bosses talk about improving  productivity,  they  are  never
talking about themselves.