From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Mon, 21 Jul 2014 13:30:19 +0200 Subject: [U-Boot] [PATCHv2] socfpga: cleanup socfpga_dw_mmc In-Reply-To: <20140721103035.GA13156@amd.pavel.ucw.cz> References: <20140716123422.GA8844@amd.pavel.ucw.cz> <20140716125238.CF3833804B5@gemini.denx.de> <20140721103035.GA13156@amd.pavel.ucw.cz> Message-ID: <20140721113019.GA13727@amd.pavel.ucw.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Cleanups as suggested by wd on mailing list. Signed-off-by: Pavel Machek --- v2: calloc is actually needed, document it. --- a/drivers/mmc/socfpga_dw_mmc.c +++ b/drivers/mmc/socfpga_dw_mmc.c @@ -16,8 +16,6 @@ static const struct socfpga_clock_manager *clock_manager_base = static const struct socfpga_system_manager *system_manager_base = (void *)SOCFPGA_SYSMGR_ADDRESS; -static char *SOCFPGA_NAME = "SOCFPGA DWMMC"; - #define CLKMGR_PERPLLGRP_EN_SDMMCCLK_MASK (1 << 8) static void socfpga_dwmci_clksel(struct dwmci_host *host) @@ -47,14 +45,16 @@ static void socfpga_dwmci_clksel(struct dwmci_host *host) int socfpga_dwmmc_init(u32 regbase, int bus_width, int index) { - struct dwmci_host *host = NULL; + struct dwmci_host *host; + + /* calloc for zero init */ host = calloc(sizeof(struct dwmci_host), 1); if (!host) { printf("dwmci_host calloc fail!\n"); return -1; } - host->name = SOCFPGA_NAME; + host->name = "SOCFPGA DWMMC"; host->ioaddr = (void *)regbase; host->buswidth = bus_width; host->clksel = socfpga_dwmci_clksel; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html