All of lore.kernel.org
 help / color / mirror / Atom feed
From: tim@buttersideup.com (Tim Small)
To: linux-ide@vger.kernel.org
Cc: tj@kernel.org
Subject: [PATCH] sata_sil24: Identify which card suffered IRQ status error
Date: Tue, 22 Jul 2014 14:28:00 +0100 (BST)	[thread overview]
Message-ID: <20140722132800.952BA60250@zebedee.buttersideup.com> (raw)

In machines with multiple Silicon Image 3124 and/or 3132 cards, there is no
way to tell which card is the culprit when the sata_sil24 interrupt handler
gets a bad status.

Tested-by: tim@seoss.co.uk
Signed-off-by: tim@seoss.co.uk

---

I got the following fault on a machine with five SiI3124 / 3132 cards in total
so I patched the driver to report the PCI slot number too.  The resulting code
seems to identify the card as desired...

old output:

sata_sil24: IRQ status == 0xffffffff, PCI fault or device removal?


new output:

sata_sil24 0000:08:04.0: IRQ status == 0xffffffff, PCI fault or device removal?


Regards,

Tim.



diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index 0534890..d81b20d 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -1154,8 +1154,8 @@ static irqreturn_t sil24_interrupt(int irq, void *dev_instance)
 	status = readl(host_base + HOST_IRQ_STAT);
 
 	if (status == 0xffffffff) {
-		printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, "
-		       "PCI fault or device removal?\n");
+		dev_err(host->dev, "IRQ status == 0xffffffff, "
+			"PCI fault or device removal?\n");
 		goto out;
 	}
 

             reply	other threads:[~2014-07-22 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 13:28 Tim Small [this message]
2014-07-22 14:09 ` [PATCH] sata_sil24: Identify which card suffered IRQ status error Tejun Heo
2014-07-22 14:10 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722132800.952BA60250@zebedee.buttersideup.com \
    --to=tim@buttersideup.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.