From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver Date: Tue, 22 Jul 2014 10:51:22 -0700 Message-ID: <20140722175121.GA5489@core.coreip.homeip.net> References: <1405197014-25225-1-git-send-email-berthe.ab@gmail.com> <1405197014-25225-4-git-send-email-berthe.ab@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Walleij Cc: linux-mips@linux-mips.org, "linux-fbdev@vger.kernel.org" , "linux-sh@vger.kernel.org" , Benjamin Herrenschmidt , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Lee Jones , Matthew Garrett , Samuel Ortiz , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Tomi Valkeinen , "linux-serial@vger.kernel.org" , Linux Input , abdoulaye berthe , Alexandre Courbot , Bryan Wu , "arm@kernel.org" , "linux-gpio@vger.kernel.org" , Mark Brown , Michael List-Id: linux-gpio@vger.kernel.org On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote: > On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe wrote: > > Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be > applied. We're getting rid of the return value from gpiochip_remove(). > > > this remove all reference to gpio_remove retval in all driver > > except pinctrl and gpio. the same thing is done for gpio and > > pinctrl in two different patches. > > > > Signed-off-by: abdoulaye berthe > (...) > > I think this patch probably needs to be broken down per-subsystem as it > hits all over the map. But let's start requesting ACKs for the > individual pieces. > Actually I think it will be OK to merge because there is likely not much churn > around these code sites. > > I'm a bit torn between just wanting a big patch for this hitting drivers/gpio > and smaller patches hitting one subsystem at a time. We should be able > to hammer this in one switch strike. ... > > > drivers/input/keyboard/adp5588-keys.c | 4 +--- > > drivers/input/keyboard/adp5589-keys.c | 4 +--- > > drivers/input/touchscreen/ad7879.c | 10 +++------- > > Dmitry can you ACK this? Acked-by: Dmitry Torokhov -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 22 Jul 2014 20:01:00 +0200 (CEST) Received: from mail-pd0-f169.google.com ([209.85.192.169]:50387 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6863268AbaGVRvha5N3V (ORCPT ); Tue, 22 Jul 2014 19:51:37 +0200 Received: by mail-pd0-f169.google.com with SMTP id y10so997pdj.14 for ; Tue, 22 Jul 2014 10:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=he+7o/W6/LmRR2eKo/moak+bACJUcV2sS2zwwQWexFM=; b=uP1axbuy1atyR0ebDL+qjkFL4MmWNaBkCWdiUXwGmBz4sF9RLv/JdSapJduWTosWND 7Z5VluA7qh6t/X5hdP6yekUzQTsQhkt97TjHEo77T1CHQU/UmOE5LiNgvnEG5brkcN1k x83agX38bplgVk2UaordhWHs9Ro6/WZ8bAJF8pL1B5JCqglrGUq2PweQ+Q+xcwoPSEgb fHJ5G0brluUbsDVAJR9NuxeAu2njvMnMFO2nq7XtdLhelZy1nKJWsYufZg6+8uPDSN2c ZkJqX8FjT8a8PMD/p2MeBrWwDjjj2EMeE4s5WBh8AHm2T8QYUIjeewYq/7D89dmd1gaZ UcEA== X-Received: by 10.69.2.35 with SMTP id bl3mr24916141pbd.83.1406051487846; Tue, 22 Jul 2014 10:51:27 -0700 (PDT) Received: from mailhub.coreip.homeip.net (c-50-136-245-103.hsd1.ca.comcast.net. [50.136.245.103]) by mx.google.com with ESMTPSA id q1sm1384529pdd.10.2014.07.22.10.51.25 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 22 Jul 2014 10:51:26 -0700 (PDT) Date: Tue, 22 Jul 2014 10:51:22 -0700 From: Dmitry Torokhov To: Linus Walleij Cc: abdoulaye berthe , "arm@kernel.org" , Ralf Baechle , Benjamin Herrenschmidt , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Jiri Kosina , Bryan Wu , Mauro Carvalho Chehab , Lee Jones , Samuel Ortiz , Matthew Garrett , Michael Buesch , Greg KH , Tomi Valkeinen , Mark Brown , Liam Girdwood , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-mips@linux-mips.org, "linux-sh@vger.kernel.org" , Linux Input , "linux-media@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver Message-ID: <20140722175121.GA5489@core.coreip.homeip.net> References: <1405197014-25225-1-git-send-email-berthe.ab@gmail.com> <1405197014-25225-4-git-send-email-berthe.ab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 41485 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dmitry.torokhov@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote: > On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe wrote: > > Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be > applied. We're getting rid of the return value from gpiochip_remove(). > > > this remove all reference to gpio_remove retval in all driver > > except pinctrl and gpio. the same thing is done for gpio and > > pinctrl in two different patches. > > > > Signed-off-by: abdoulaye berthe > (...) > > I think this patch probably needs to be broken down per-subsystem as it > hits all over the map. But let's start requesting ACKs for the > individual pieces. > Actually I think it will be OK to merge because there is likely not much churn > around these code sites. > > I'm a bit torn between just wanting a big patch for this hitting drivers/gpio > and smaller patches hitting one subsystem at a time. We should be able > to hammer this in one switch strike. ... > > > drivers/input/keyboard/adp5588-keys.c | 4 +--- > > drivers/input/keyboard/adp5589-keys.c | 4 +--- > > drivers/input/touchscreen/ad7879.c | 10 +++------- > > Dmitry can you ACK this? Acked-by: Dmitry Torokhov -- Dmitry