From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 22 Jul 2014 16:13:31 -0700 From: Greg KH Subject: Re: [PATCH 3/8 v2] staging: unisys: move installer to sysfs and split fields Message-ID: <20140722231331.GA1806@kroah.com> References: <1406037392-31030-1-git-send-email-benjamin.romer@unisys.com> <1406037392-31030-4-git-send-email-benjamin.romer@unisys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406037392-31030-4-git-send-email-benjamin.romer@unisys.com> List-ID: To: Benjamin Romer Cc: driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com On Tue, Jul 22, 2014 at 09:56:27AM -0400, Benjamin Romer wrote: > The installer entry in /proc/visorchipset/installer was composed of three > separate fields as one entry. This patch removes the proc entry and associated > functions, and creates new fields with distinct entries under sysfs in the > visorchipset/install directory. The fields are: > > textid: used to send the ID of a string that should be displayed on > s-Par's automatic installation progress screen. Setting this > field when not in installation mode (boottotool was set on > the previous guest boot) has no effect. > > remaining_steps: used to set the value of the progress bar on the > s-Par automatic installation progress screen. This field has > no effect if not in installation mode. > > error: used to send the ID of a string that should be displayed on > s-Par's automatic installation progress screen when an error > is encountered during installation. This field has no effect > if not in installation mode. > > Signed-off-by: Benjamin Romer > --- > v2: attribute creation was fixed and checks for controlvm_channel pointer were > removed. > > .../unisys/visorchipset/visorchipset_main.c | 233 ++++++++++----------- > 1 file changed, 106 insertions(+), 127 deletions(-) > > diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c > index 48db6ee..a20e21b 100644 > --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c > +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c > @@ -144,16 +144,6 @@ static VISORCHANNEL *ControlVm_channel; > static ssize_t visorchipset_proc_read_writeonly(struct file *file, > char __user *buf, > size_t len, loff_t *offset); > -static ssize_t proc_read_installer(struct file *file, char __user *buf, > - size_t len, loff_t *offset); > -static ssize_t proc_write_installer(struct file *file, > - const char __user *buffer, > - size_t count, loff_t *ppos); > - > -static const struct file_operations proc_installer_fops = { > - .read = proc_read_installer, > - .write = proc_write_installer, > -}; > > typedef struct { > U8 __iomem *ptr; /* pointer to base address of payload pool */ > @@ -315,9 +305,30 @@ static ssize_t boottotool_store(struct device *dev, > struct device_attribute *attr, const char *buf, size_t count); > static DEVICE_ATTR_RW(boottotool); > > +static ssize_t error_show(struct device *dev, struct device_attribute *attr, > + char *buf); > +static ssize_t error_store(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count); > +static DEVICE_ATTR_RW(error); > + > +static ssize_t textid_show(struct device *dev, struct device_attribute *attr, > + char *buf); > +static ssize_t textid_store(struct device *dev, struct device_attribute *attr, You have an extra tab character in this line :( > +ssize_t remaining_steps_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + U16 remainingSteps; Minor nit, I took your previous patch, but as this needs to be redone, plese, for new functions, use the proper kernel variable types, like u16 here, not made-up-ones-for-this-driver-alone. thanks, greg k-h