From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open Date: Wed, 23 Jul 2014 11:38:47 +0100 Message-ID: <20140723103847.GA13688__22804.7826131389$1406112039$gmane$org@stefanha-thinkpad.redhat.com> References: <1400860669-21593-1-git-send-email-roger.pau@citrix.com> <1400860669-21593-3-git-send-email-roger.pau@citrix.com> <20140527132943.GD31463@stefanha-thinkpad.redhat.com> <53CE4F07.40804@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8742181433399140042==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X9twk-00024w-Nz for xen-devel@lists.xenproject.org; Wed, 23 Jul 2014 10:38:54 +0000 Received: by mail-wi0-f174.google.com with SMTP id d1so7560855wiv.1 for ; Wed, 23 Jul 2014 03:38:53 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi , Roger Pau =?iso-8859-1?Q?Monn=E9?= List-Id: xen-devel@lists.xenproject.org --===============8742181433399140042== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2014 at 01:26:00PM +0100, Stefano Stabellini wrote: > On Tue, 22 Jul 2014, Roger Pau Monn=E9 wrote: > > On 27/05/14 15:29, Stefan Hajnoczi wrote: > > > On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote: > > >> The current behaviour of tap_open for BSD systems differ greatly from > > >> it's Linux counterpart. Since FreeBSD supports interface renaming and > > >> tap device cloning by opening /dev/tap, implement a FreeBSD specific > > >> version of tap_open that behaves like it's Linux counterpart. > > >> > > >> This is specially important for toolstacks that use Qemu (like Xen > > >> libxl), in order to have a unified behaviour across suported > > >> platforms. > > >> > > >> Signed-off-by: Roger Pau Monn=E9 > > >> Cc: xen-devel@lists.xenproject.org > > >> Cc: Stefano Stabellini > > >> Cc: Anthony Liguori > > >> Cc: Stefan Hajnoczi > > >> --- > > >> net/tap-bsd.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++- > > >> 1 files changed, 69 insertions(+), 1 deletions(-) > > >=20 > > > Reviewed-by: Stefan Hajnoczi > >=20 > > I still don't see this committed to the repository, should I ping someo= ne? >=20 > I was assuming that this patch would go via some other tree. But if > Stefan is OK I could pick it up and submit a pull request for both patch > 1 and 2 of this series. I'm fine with that. I only reviewed this patch since it affects the net subsystem and left the series as a whole for someone to merge. Stefan --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTz5C3AAoJEJykq7OBq3PI3PYH/RAkSiLE1mdPxjZLidJBUkD3 7Y9HrKRVUss0WusM9acauaFNPV+DuxFkeOxyTyb5rnF8XV5CAblW38A+alBS2B0x HCeFawqK6ympnyvrHKxAwPzFGl+eaI/TDOLMvwTU+qf60EI87AWSbXM/SN8zueDz cWTg4XYxdK6q/UHX2Fkd/CrfJ9MGrZF7EFa8Igq/s/YPxv3reTS+KYWO5N+D5h2u hngUmUGgSV8dLB/Ju1RCDAd7ATYLp1Ff1LOK0lNtQuhPFCr8Qn/nTS4Ks4OUsn7o 35kd4HzEy4q2N6bkbXfTrawnj9xqbHBtBIlmGf1b2CHCRD1m1igBfBYnt8alCjw= =rL8z -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH-- --===============8742181433399140042== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8742181433399140042==--