From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 06/12] drm: fix __alpha__ PCI lookup
Date: Wed, 23 Jul 2014 21:36:55 +0200
Message-ID: <20140723193655.GE15237@phenom.ffwll.local>
References: <1406129207-1302-1-git-send-email-dh.herrmann@gmail.com>
 <1406129207-1302-7-git-send-email-dh.herrmann@gmail.com>
 <20140723192948.GB15237@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7343389BFD
 for <dri-devel@lists.freedesktop.org>; Wed, 23 Jul 2014 12:36:46 -0700 (PDT)
Received: by mail-wg0-f46.google.com with SMTP id m15so1667154wgh.17
 for <dri-devel@lists.freedesktop.org>; Wed, 23 Jul 2014 12:36:45 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140723192948.GB15237@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, Jul 23, 2014 at 09:29:48PM +0200, Daniel Vetter wrote:
> On Wed, Jul 23, 2014 at 05:26:41PM +0200, David Herrmann wrote:
> > Testing the return value of list_entry() for NULL is a no-op (as it is
> > just a fancy container_of() / offsetof()). Drop the superfluous if-clause
> > and instead verify the actual root-node is available. This is probably
> > what it was meant to test for from the beginning, anyway.
> > 
> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> 
> Oh drm handling of alpha. I've tried to dig out how this all works
> together and it's dangerous. drm totally ignored this thing called dma api
> so needed to handle cpu phys address vs. bus address offsets itself. If
> you munge around also in the agp code (which is really only used by drm)
> then you'll notice that it's handled completely differently on alpha vs.
> ppc.
> 
> Tbh I'd wait until this is all officially dead and then rip it all out.

I dare you for a patch to rip out alpha drm handling completely though ;-)
ppc probably needs to stay a bit longer, there's still lots of apple
hardware with radeons around.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch