All of lore.kernel.org
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Wang YanQing <udknight@gmail.com>,
	linus.walleij@linaro.org, jhovold@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303
Date: Thu, 24 Jul 2014 10:34:47 +0100	[thread overview]
Message-ID: <20140724103447.047627ee@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <20140723162129.GB6871@kroah.com>

On Wed, 23 Jul 2014 09:21:29 -0700
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Jul 23, 2014 at 05:03:14PM +0100, One Thousand Gnomes wrote:
> > > +		if (gpiochip_remove(&spriv->gpio->gpio_chip))
> > > +			dev_err(&serial->interface->dev, "unable to remove gpio_chip?\n");
> > > +		kfree(spriv->gpio);
> > > +	}
> > > +#endif
> > >  	kfree(spriv);
> > 
> > Only other question I have - if I have multiple PL2303HX adapters how
> > will I work out which GPIO lines belong to which /dev/ttyUSB* interface ?
> 
> sysfs _should_ show you this, as it should point to the "parent" device,
> which will be associated with the ttyUSB interface.  Well, both the tty
> device and the gpio device will have the same parent, is that good
> enough to determine this, or should the gpio device have the tty device
> as its parent?

Good point - that's probably sufficient as is. The GPIO and tty lines are
sometimes used together and sometimes not.

Alan

      reply	other threads:[~2014-07-24  9:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20  6:38 [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303 Wang YanQing
2014-07-20  9:19 ` Daniele Forsi
2014-07-23 16:03 ` One Thousand Gnomes
2014-07-23 16:21   ` Greg KH
2014-07-24  9:34     ` One Thousand Gnomes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140724103447.047627ee@alan.etchedpixels.co.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhovold@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.