From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 09/19] ARM64 / ACPI: Move the initialization of cpu_logical_map(0) before acpi_boot_init() Date: Fri, 25 Jul 2014 13:18:39 +0100 Message-ID: <20140725121839.GC19632@leverpostej> References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-10-git-send-email-hanjun.guo@linaro.org> <20140724152103.GB26190@leverpostej> <53D233CC.1070006@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:39484 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbaGYMSy (ORCPT ); Fri, 25 Jul 2014 08:18:54 -0400 Content-Disposition: inline In-Reply-To: <53D233CC.1070006@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo Cc: Catalin Marinas , "Rafael J. Wysocki" , "graeme.gregory@linaro.org" , Arnd Bergmann , "grant.likely@linaro.org" , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On Fri, Jul 25, 2014 at 11:39:08AM +0100, Hanjun Guo wrote: > On 2014-7-24 23:21, Mark Rutland wrote: > > On Thu, Jul 24, 2014 at 02:00:15PM +0100, Hanjun Guo wrote: > >> Move the initialization of cpu_logical_map(0) before acpi_boot_init() > >> to remove the duplicated initialization of cpu_logical_map(0). > > > > It always make sense to initialise CPU0's logical map entry from the > > hardware values, so you could do this earlier in the series, before you > > introduce any ACPI code. Then you don't have the churn in acpi.c > > ok, I will prepare a separate patch to do this before ACPI code, does it > make sense to you? Yes. Just put that at the start of the series. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759914AbaGYMSz (ORCPT ); Fri, 25 Jul 2014 08:18:55 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:39484 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbaGYMSy (ORCPT ); Fri, 25 Jul 2014 08:18:54 -0400 Date: Fri, 25 Jul 2014 13:18:39 +0100 From: Mark Rutland To: Hanjun Guo Cc: Catalin Marinas , "Rafael J. Wysocki" , "graeme.gregory@linaro.org" , Arnd Bergmann , "grant.likely@linaro.org" , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 09/19] ARM64 / ACPI: Move the initialization of cpu_logical_map(0) before acpi_boot_init() Message-ID: <20140725121839.GC19632@leverpostej> References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-10-git-send-email-hanjun.guo@linaro.org> <20140724152103.GB26190@leverpostej> <53D233CC.1070006@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53D233CC.1070006@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 25, 2014 at 11:39:08AM +0100, Hanjun Guo wrote: > On 2014-7-24 23:21, Mark Rutland wrote: > > On Thu, Jul 24, 2014 at 02:00:15PM +0100, Hanjun Guo wrote: > >> Move the initialization of cpu_logical_map(0) before acpi_boot_init() > >> to remove the duplicated initialization of cpu_logical_map(0). > > > > It always make sense to initialise CPU0's logical map entry from the > > hardware values, so you could do this earlier in the series, before you > > introduce any ACPI code. Then you don't have the churn in acpi.c > > ok, I will prepare a separate patch to do this before ACPI code, does it > make sense to you? Yes. Just put that at the start of the series. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Fri, 25 Jul 2014 13:18:39 +0100 Subject: [PATCH 09/19] ARM64 / ACPI: Move the initialization of cpu_logical_map(0) before acpi_boot_init() In-Reply-To: <53D233CC.1070006@linaro.org> References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-10-git-send-email-hanjun.guo@linaro.org> <20140724152103.GB26190@leverpostej> <53D233CC.1070006@linaro.org> Message-ID: <20140725121839.GC19632@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 25, 2014 at 11:39:08AM +0100, Hanjun Guo wrote: > On 2014-7-24 23:21, Mark Rutland wrote: > > On Thu, Jul 24, 2014 at 02:00:15PM +0100, Hanjun Guo wrote: > >> Move the initialization of cpu_logical_map(0) before acpi_boot_init() > >> to remove the duplicated initialization of cpu_logical_map(0). > > > > It always make sense to initialise CPU0's logical map entry from the > > hardware values, so you could do this earlier in the series, before you > > introduce any ACPI code. Then you don't have the churn in acpi.c > > ok, I will prepare a separate patch to do this before ACPI code, does it > make sense to you? Yes. Just put that at the start of the series. Thanks, Mark.