From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760288AbaGYN1Q (ORCPT ); Fri, 25 Jul 2014 09:27:16 -0400 Received: from mail.kernel.org ([198.145.19.201]:56895 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760017AbaGYN1O (ORCPT ); Fri, 25 Jul 2014 09:27:14 -0400 Date: Fri, 25 Jul 2014 10:27:05 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, David Ahern , Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Paul Mackerras , Stephane Eranian Subject: Re: [PATCH 28/52] perf script: Allow callchains if any event samples them Message-ID: <20140725132705.GJ7831@kernel.org> References: <1406035081-14301-1-git-send-email-adrian.hunter@intel.com> <1406035081-14301-29-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406035081-14301-29-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jul 22, 2014 at 04:17:37PM +0300, Adrian Hunter escreveu: > perf script was not displaying callchains if any selected > event did not have PERF_SAMPLE_CALLCHAIN. Change this to > disable callchains only if all selected events do not have > PERF_SAMPLE_CALLCHAIN. I wonder if some other tool gets this wrong as well, report maybe? Perhaps we need to have this check in some perf_evlist method? Wonder how report/top, i.e. the hists browser will react with some events having callchains while some don't, specially with this new children stuff, Namhyung, can you please check that? Adrian, can you, in a case like that, provide a command line that creates such combo? I.e. how to create a perf.data file with multiple events with some having callchains while some don't. As a rule, it is better to ease reproducing behaviour you mention when fixing stuff, so that quickly others can try and go on trying to fix it. Thanks, - Arnaldo > Signed-off-by: Adrian Hunter > --- > tools/perf/builtin-script.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 582da97..c1a56f2 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -184,10 +184,6 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel, > if (perf_evsel__check_stype(evsel, PERF_SAMPLE_IP, "IP", > PERF_OUTPUT_IP)) > return -EINVAL; > - > - if (!no_callchain && > - !(attr->sample_type & PERF_SAMPLE_CALLCHAIN)) > - symbol_conf.use_callchain = false; > } > > if (PRINT_FIELD(ADDR) && > @@ -290,6 +286,19 @@ static int perf_session__check_output_opt(struct perf_session *session) > set_print_ip_opts(&evsel->attr); > } > > + if (!no_callchain) { > + bool use_callchain = false; > + > + evlist__for_each(session->evlist, evsel) { > + if (evsel->attr.sample_type & PERF_SAMPLE_CALLCHAIN) { > + use_callchain = true; > + break; > + } > + } > + if (!use_callchain) > + symbol_conf.use_callchain = false; > + } > + > /* > * set default for tracepoints to print symbols only > * if callchains are present > -- > 1.8.3.2