All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ronnie Sahlberg <sahlberg@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 4/5] refs.c: update rename_ref to use a transaction
Date: Fri, 25 Jul 2014 13:00:09 -0700	[thread overview]
Message-ID: <20140725200009.GJ12427@google.com> (raw)
In-Reply-To: <1406307521-10339-5-git-send-email-sahlberg@google.com>

Ronnie Sahlberg wrote:

> Change refs.c to use a single transaction to copy/rename both the refs and
> its reflog.

Yay!

>             Since we are no longer using rename() to move the reflog file
> we no longer need to disallow rename_ref for refs with a symlink for its
> reflog so we can remove that test from the testsuite.

It's generally better to update the testsuite with the new expected
behavior instead. :)

  reply	other threads:[~2014-07-25 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 16:58 [PATCH 0/5] ref-transactions-rename Ronnie Sahlberg
2014-07-25 16:58 ` [PATCH 1/5] refs.c: allow passing raw git_committer_info as email to _update_reflog Ronnie Sahlberg
2014-07-25 19:37   ` Jonathan Nieder
2014-07-28 18:01     ` Ronnie Sahlberg
2014-07-28 23:39       ` Eric Sunshine
2014-07-25 16:58 ` [PATCH 2/5] refs.c: return error instead of dying when locking fails during transaction Ronnie Sahlberg
2014-07-25 19:40   ` Jonathan Nieder
2014-07-28 19:01     ` Ronnie Sahlberg
2014-07-25 16:58 ` [PATCH 3/5] refs.c: use packed refs when deleting refs during a transaction Ronnie Sahlberg
2014-07-25 19:58   ` Jonathan Nieder
2014-07-25 16:58 ` [PATCH 4/5] refs.c: update rename_ref to use " Ronnie Sahlberg
2014-07-25 20:00   ` Jonathan Nieder [this message]
2014-07-25 16:58 ` [PATCH 5/5] refs.c: rollback the lockfile before we die() in repack_without_refs Ronnie Sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725200009.GJ12427@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sahlberg@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.