From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Date: Mon, 28 Jul 2014 14:05:33 +0000 Subject: Re: [RFC PATCH 2/2] of/clk: use "clkops-clocks" to specify clocks handled by clock_ops domain Message-Id: <20140728140533.6E916C4116F@trevor.secretlab.ca> List-Id: References: <1398334403-26181-1-git-send-email-geert+renesas@glider.be> <1402592023-13416-1-git-send-email-grygorii.strashko@ti.com> <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> In-Reply-To: <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko wrote: > Use "clkops-clocks" property to specify clocks handled by > clock_ops domain PM domain. Only clocks defined in "clkops-clocks" > set of clocks will be handled by Runtime PM through clock_ops > Pm domain. > > Signed-off-by: Grygorii Strashko > --- > drivers/of/of_clk.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/of_clk.c b/drivers/of/of_clk.c > index 35f5e9f..5f9b90e 100644 > --- a/drivers/of/of_clk.c > +++ b/drivers/of/of_clk.c > @@ -86,11 +86,8 @@ int of_clk_register_runtime_pm_clocks(struct device_node *np, > struct clk *clk; > int error; > > - for (i = 0; (clk = of_clk_get(np, i)) && !IS_ERR(clk); i++) { > - if (!clk_may_runtime_pm(clk)) { > - clk_put(clk); > - continue; > - } > + for (i = 0; (clk = of_clk_get_from_set(np, "clkops", i)) && > + !IS_ERR(clk); i++) { This really looks like an ABI break to me. What happens to all the existing platforms who don't have this new clkops-clocks in their device tree? g. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbaG1OFn (ORCPT ); Mon, 28 Jul 2014 10:05:43 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:42872 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752844AbaG1OFk (ORCPT ); Mon, 28 Jul 2014 10:05:40 -0400 From: Grant Likely Subject: Re: [RFC PATCH 2/2] of/clk: use "clkops-clocks" to specify clocks handled by clock_ops domain To: Grygorii Strashko , geert+renesas@glider.be Cc: laurent.pinchart@ideasonboard.com, ulf.hansson@linaro.org, khilman@linaro.org, mturquette@linaro.org, tomasz.figa@gmail.com, ben.dooks@codethink.co.uk, horms@verge.net.au, magnus.damm@gmail.com, rjw@rjwysocki.net, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Grygorii Strashko In-Reply-To: <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> References: <1398334403-26181-1-git-send-email-geert+renesas@glider.be> <1402592023-13416-1-git-send-email-grygorii.strashko@ti.com> <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> Date: Mon, 28 Jul 2014 08:05:33 -0600 Message-Id: <20140728140533.6E916C4116F@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko wrote: > Use "clkops-clocks" property to specify clocks handled by > clock_ops domain PM domain. Only clocks defined in "clkops-clocks" > set of clocks will be handled by Runtime PM through clock_ops > Pm domain. > > Signed-off-by: Grygorii Strashko > --- > drivers/of/of_clk.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/of_clk.c b/drivers/of/of_clk.c > index 35f5e9f..5f9b90e 100644 > --- a/drivers/of/of_clk.c > +++ b/drivers/of/of_clk.c > @@ -86,11 +86,8 @@ int of_clk_register_runtime_pm_clocks(struct device_node *np, > struct clk *clk; > int error; > > - for (i = 0; (clk = of_clk_get(np, i)) && !IS_ERR(clk); i++) { > - if (!clk_may_runtime_pm(clk)) { > - clk_put(clk); > - continue; > - } > + for (i = 0; (clk = of_clk_get_from_set(np, "clkops", i)) && > + !IS_ERR(clk); i++) { This really looks like an ABI break to me. What happens to all the existing platforms who don't have this new clkops-clocks in their device tree? g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [RFC PATCH 2/2] of/clk: use "clkops-clocks" to specify clocks handled by clock_ops domain Date: Mon, 28 Jul 2014 08:05:33 -0600 Message-ID: <20140728140533.6E916C4116F@trevor.secretlab.ca> References: <1398334403-26181-1-git-send-email-geert+renesas@glider.be> <1402592023-13416-1-git-send-email-grygorii.strashko@ti.com> <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> Return-path: In-Reply-To: <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> Sender: linux-sh-owner@vger.kernel.org To: geert+renesas@glider.be Cc: laurent.pinchart@ideasonboard.com, ulf.hansson@linaro.org, khilman@linaro.org, mturquette@linaro.org, tomasz.figa@gmail.com, ben.dooks@codethink.co.uk, horms@verge.net.au, magnus.damm@gmail.com, rjw@rjwysocki.net, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Grygorii Strashko List-Id: devicetree@vger.kernel.org On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko wrote: > Use "clkops-clocks" property to specify clocks handled by > clock_ops domain PM domain. Only clocks defined in "clkops-clocks" > set of clocks will be handled by Runtime PM through clock_ops > Pm domain. > > Signed-off-by: Grygorii Strashko > --- > drivers/of/of_clk.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/of_clk.c b/drivers/of/of_clk.c > index 35f5e9f..5f9b90e 100644 > --- a/drivers/of/of_clk.c > +++ b/drivers/of/of_clk.c > @@ -86,11 +86,8 @@ int of_clk_register_runtime_pm_clocks(struct device_node *np, > struct clk *clk; > int error; > > - for (i = 0; (clk = of_clk_get(np, i)) && !IS_ERR(clk); i++) { > - if (!clk_may_runtime_pm(clk)) { > - clk_put(clk); > - continue; > - } > + for (i = 0; (clk = of_clk_get_from_set(np, "clkops", i)) && > + !IS_ERR(clk); i++) { This really looks like an ABI break to me. What happens to all the existing platforms who don't have this new clkops-clocks in their device tree? g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Mon, 28 Jul 2014 08:05:33 -0600 Subject: [RFC PATCH 2/2] of/clk: use "clkops-clocks" to specify clocks handled by clock_ops domain In-Reply-To: <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> References: <1398334403-26181-1-git-send-email-geert+renesas@glider.be> <1402592023-13416-1-git-send-email-grygorii.strashko@ti.com> <1402592023-13416-3-git-send-email-grygorii.strashko@ti.com> Message-ID: <20140728140533.6E916C4116F@trevor.secretlab.ca> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 12 Jun 2014 19:53:43 +0300, Grygorii Strashko wrote: > Use "clkops-clocks" property to specify clocks handled by > clock_ops domain PM domain. Only clocks defined in "clkops-clocks" > set of clocks will be handled by Runtime PM through clock_ops > Pm domain. > > Signed-off-by: Grygorii Strashko > --- > drivers/of/of_clk.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/of_clk.c b/drivers/of/of_clk.c > index 35f5e9f..5f9b90e 100644 > --- a/drivers/of/of_clk.c > +++ b/drivers/of/of_clk.c > @@ -86,11 +86,8 @@ int of_clk_register_runtime_pm_clocks(struct device_node *np, > struct clk *clk; > int error; > > - for (i = 0; (clk = of_clk_get(np, i)) && !IS_ERR(clk); i++) { > - if (!clk_may_runtime_pm(clk)) { > - clk_put(clk); > - continue; > - } > + for (i = 0; (clk = of_clk_get_from_set(np, "clkops", i)) && > + !IS_ERR(clk); i++) { This really looks like an ABI break to me. What happens to all the existing platforms who don't have this new clkops-clocks in their device tree? g.