From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbaG2CM7 (ORCPT ); Mon, 28 Jul 2014 22:12:59 -0400 Received: from mail.kernel.org ([198.145.19.201]:55042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbaG2CM6 (ORCPT ); Mon, 28 Jul 2014 22:12:58 -0400 Date: Tue, 29 Jul 2014 04:12:51 +0200 From: Sebastian Reichel To: Felipe Balbi Cc: Tony Lindgren , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , bcousson@baylibre.com, linux@arm.linux.org.uk, khilman@deeprootsystems.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 19/35] arm: omap: irq: drop ti,intc-size support Message-ID: <20140729021251.GA4421@earth.universe> References: <1406582183-696-1-git-send-email-balbi@ti.com> <1406582183-696-20-git-send-email-balbi@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <1406582183-696-20-git-send-email-balbi@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jul 28, 2014 at 04:16:07PM -0500, Felipe Balbi wrote: > we don't need that anymore since specific > devices are passing correct compatible flags. >=20 > Signed-off-by: Felipe Balbi > --- > arch/arm/mach-omap2/irq.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c > index 7a4ead3..e70c26e 100644 > --- a/arch/arm/mach-omap2/irq.c > +++ b/arch/arm/mach-omap2/irq.c > @@ -313,9 +313,6 @@ static int __init intc_of_init(struct device_node *no= de, > if (of_device_is_compatible(node, "ti,am33xx-intc")) > nr_irq =3D 128; > =20 > - if (of_property_read_u32(node, "ti,intc-size", &nr_irq)) > - pr_warn("unable to get intc-size, default to %d\n", nr_irq); > - keeping this code would avoid breaking the DT API. I suggest to change it to something like the following: if (!of_property_read_u32(...)) dev_warn(dev, "ti,intc-size is deprecated, please update your DT file"); Apart from that the Documentation [0] should be updated (add deprecation notice for ti,intc-size and add new compatible values) and maybe moved to [1] (where other SoCs put their irq controller binding docs). [0] Documentation/devicetree/bindings/arm/omap/intc.txt [1] Documentation/devicetree/bindings/interrupt-controller/ -- Sebastian --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJT1wMiAAoJENju1/PIO/qaRnMP/R+sSdbjQripBSGEtSUy2XP2 iFwUEoO7CyxjYhcCOkc/Lnpa0X8z77WE3rxHCp/e0S/buu2xtY1W0Gp4MWWKrXov PvK4/P0QycWAZ7YhC8Tu9O0JHiuopYTEZmcCpa9KE6vdUpC0iY5tUUO4DzGkxXZK L/lN5Cjcvgkejt811QK7JPqRKjvAcoGwcOzELWCI9TcJTO9zRxn5RPmUYiwJr6AN d4nQdgNJgKfoZl8Po1ZiW3RTU4cpBOtj1VdKp8fQH6a2nGPmzQdcfxgQO1ConnwV W+3uxQBz0usZLee5l3kgC3AA7vrZ97Mtro/QcAJHvOH022kJVApNHYgX/ksAd87R ZQEvODFzmqXNQ4p2cHYcm9pqsahDSD574H2PKKRoD62hwG+xKrplEXG72l5R2zA/ FKHW9olFVoxr3adWNqscHUXc3cS24Xy5kzamwlzT6TNWnnWglfhS0E4yRM86SgZf Rp4KNi53KrtOkGCh8O6Csqy0YQK1H6ldTrjhZwrYkT1sNv+znrj59WuvvpttMonV /UuYyP1HkAxQlRm7va0pMffKrd9p1QsIsj5RFimV9KjbxsN+u+wq/Hl6il/a71/E 3/FyBTSu2lXgNvjRYW/zKEXY5rEDxJjj4wLjJLL80GYhy2yCaTgCw625hNovPZgb 2dyeFuaZ3fFh6cjCU0Dg =adkY -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Reichel Subject: Re: [PATCH 19/35] arm: omap: irq: drop ti,intc-size support Date: Tue, 29 Jul 2014 04:12:51 +0200 Message-ID: <20140729021251.GA4421@earth.universe> References: <1406582183-696-1-git-send-email-balbi@ti.com> <1406582183-696-20-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Return-path: Content-Disposition: inline In-Reply-To: <1406582183-696-20-git-send-email-balbi-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: Tony Lindgren , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jul 28, 2014 at 04:16:07PM -0500, Felipe Balbi wrote: > we don't need that anymore since specific > devices are passing correct compatible flags. >=20 > Signed-off-by: Felipe Balbi > --- > arch/arm/mach-omap2/irq.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c > index 7a4ead3..e70c26e 100644 > --- a/arch/arm/mach-omap2/irq.c > +++ b/arch/arm/mach-omap2/irq.c > @@ -313,9 +313,6 @@ static int __init intc_of_init(struct device_node *no= de, > if (of_device_is_compatible(node, "ti,am33xx-intc")) > nr_irq =3D 128; > =20 > - if (of_property_read_u32(node, "ti,intc-size", &nr_irq)) > - pr_warn("unable to get intc-size, default to %d\n", nr_irq); > - keeping this code would avoid breaking the DT API. I suggest to change it to something like the following: if (!of_property_read_u32(...)) dev_warn(dev, "ti,intc-size is deprecated, please update your DT file"); Apart from that the Documentation [0] should be updated (add deprecation notice for ti,intc-size and add new compatible values) and maybe moved to [1] (where other SoCs put their irq controller binding docs). [0] Documentation/devicetree/bindings/arm/omap/intc.txt [1] Documentation/devicetree/bindings/interrupt-controller/ -- Sebastian --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJT1wMiAAoJENju1/PIO/qaRnMP/R+sSdbjQripBSGEtSUy2XP2 iFwUEoO7CyxjYhcCOkc/Lnpa0X8z77WE3rxHCp/e0S/buu2xtY1W0Gp4MWWKrXov PvK4/P0QycWAZ7YhC8Tu9O0JHiuopYTEZmcCpa9KE6vdUpC0iY5tUUO4DzGkxXZK L/lN5Cjcvgkejt811QK7JPqRKjvAcoGwcOzELWCI9TcJTO9zRxn5RPmUYiwJr6AN d4nQdgNJgKfoZl8Po1ZiW3RTU4cpBOtj1VdKp8fQH6a2nGPmzQdcfxgQO1ConnwV W+3uxQBz0usZLee5l3kgC3AA7vrZ97Mtro/QcAJHvOH022kJVApNHYgX/ksAd87R ZQEvODFzmqXNQ4p2cHYcm9pqsahDSD574H2PKKRoD62hwG+xKrplEXG72l5R2zA/ FKHW9olFVoxr3adWNqscHUXc3cS24Xy5kzamwlzT6TNWnnWglfhS0E4yRM86SgZf Rp4KNi53KrtOkGCh8O6Csqy0YQK1H6ldTrjhZwrYkT1sNv+znrj59WuvvpttMonV /UuYyP1HkAxQlRm7va0pMffKrd9p1QsIsj5RFimV9KjbxsN+u+wq/Hl6il/a71/E 3/FyBTSu2lXgNvjRYW/zKEXY5rEDxJjj4wLjJLL80GYhy2yCaTgCw625hNovPZgb 2dyeFuaZ3fFh6cjCU0Dg =adkY -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sre@kernel.org (Sebastian Reichel) Date: Tue, 29 Jul 2014 04:12:51 +0200 Subject: [PATCH 19/35] arm: omap: irq: drop ti,intc-size support In-Reply-To: <1406582183-696-20-git-send-email-balbi@ti.com> References: <1406582183-696-1-git-send-email-balbi@ti.com> <1406582183-696-20-git-send-email-balbi@ti.com> Message-ID: <20140729021251.GA4421@earth.universe> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Mon, Jul 28, 2014 at 04:16:07PM -0500, Felipe Balbi wrote: > we don't need that anymore since specific > devices are passing correct compatible flags. > > Signed-off-by: Felipe Balbi > --- > arch/arm/mach-omap2/irq.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c > index 7a4ead3..e70c26e 100644 > --- a/arch/arm/mach-omap2/irq.c > +++ b/arch/arm/mach-omap2/irq.c > @@ -313,9 +313,6 @@ static int __init intc_of_init(struct device_node *node, > if (of_device_is_compatible(node, "ti,am33xx-intc")) > nr_irq = 128; > > - if (of_property_read_u32(node, "ti,intc-size", &nr_irq)) > - pr_warn("unable to get intc-size, default to %d\n", nr_irq); > - keeping this code would avoid breaking the DT API. I suggest to change it to something like the following: if (!of_property_read_u32(...)) dev_warn(dev, "ti,intc-size is deprecated, please update your DT file"); Apart from that the Documentation [0] should be updated (add deprecation notice for ti,intc-size and add new compatible values) and maybe moved to [1] (where other SoCs put their irq controller binding docs). [0] Documentation/devicetree/bindings/arm/omap/intc.txt [1] Documentation/devicetree/bindings/interrupt-controller/ -- Sebastian -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: