From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753886AbaG2TUO (ORCPT ); Tue, 29 Jul 2014 15:20:14 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:47909 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbaG2TUM (ORCPT ); Tue, 29 Jul 2014 15:20:12 -0400 Date: Tue, 29 Jul 2014 12:20:08 -0700 From: Brian Norris To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Thomas Gleixner , linux-kernel@vger.kernel.org, Dmitry Torokhov , Linux PM list , Dmitry Torokhov Subject: Re: [RFC][PATCH] irq: Rework IRQF_NO_SUSPENDED Message-ID: <20140729192008.GH3711@ld-irv-0074> References: <20140724212620.GO3935@laptop> <13290270.IfKaUSRMLR@vostro.rjw.lan> <20140725055847.GQ3935@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140725055847.GQ3935@laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Fri, Jul 25, 2014 at 07:58:47AM +0200, Peter Zijlstra wrote: > On Fri, Jul 25, 2014 at 01:10:36AM +0200, Rafael J. Wysocki wrote: > > Yes, drivers using enable_irq_wake() will likely want IRQF_NO_SUSPEND to > > be set for their irqactions, but that should not imply "no suspend" for > > all irqactions sharing the same desc. So I guess it may be better to go > > forth and use a global "interrupts suspended" state variable instead of the > > IRQS_SUSPENDED flag for each desc and throw away the IRQD_WAKEUP_STATE > > check from suspend_device_irqs() entirely. > > > > Peter, it looks like you'd prefer that? > > My preference would be to shoot enable_irq_wake() in the head, its > fundamentally broken. I'm curious what you mean. Are you referring to the fact that its input is simply an IRQ number (regardless of whether the IRQ is shared), not something that identifies the particular handler (e.g., struct irqaction)? Brian