From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/7] drm/i915: Only refcount ppgtt if it
 actually is one
Date: Thu, 31 Jul 2014 07:52:13 +0100
Message-ID: <20140731065213.GO21570@nuc-i3427.alporthouse.com>
References: <1406749324-2156-1-git-send-email-daniel.vetter@ffwll.ch>
 <1406749324-2156-2-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
 by gabe.freedesktop.org (Postfix) with ESMTP id 087D36E0D6
 for <intel-gfx@lists.freedesktop.org>; Wed, 30 Jul 2014 23:52:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1406749324-2156-2-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 30, 2014 at 09:41:59PM +0200, Daniel Vetter wrote:
> This essentially unbreaks non-ppgtt operation where we'd scribble over
> random memory.
> 
> While at it give the vm_to_ppgtt function a proper prefix and make it
> a bit more paranoid.

Wrong direction. If you make ggtt/ppgtt more similar we can loose
having to write fragile code.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre