From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH] crypto: initialize entry len for null input in crypto hash sg list walk Date: Fri, 1 Aug 2014 22:18:16 +0800 Message-ID: <20140801141816.GA14651@gondor.apana.org.au> References: <1405034288.2970.647.camel@schen9-DESK> <20140723130945.GA29178@gondor.apana.org.au> <1406131665.2970.820.camel@schen9-DESK> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "H. Peter Anvin" , "David S.Miller" , Chandramouli Narayanan , Jussi Kivilinna , linux-crypto@vger.kernel.org To: Tim Chen Return-path: Received: from helcar.apana.org.au ([209.40.204.226]:35843 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbaHAOSl (ORCPT ); Fri, 1 Aug 2014 10:18:41 -0400 Content-Disposition: inline In-Reply-To: <1406131665.2970.820.camel@schen9-DESK> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jul 23, 2014 at 09:07:45AM -0700, Tim Chen wrote: > On Wed, 2014-07-23 at 21:09 +0800, Herbert Xu wrote: > > On Thu, Jul 10, 2014 at 04:18:08PM -0700, Tim Chen wrote: > > > For the special case when we have a null input string, we want > > > to initialize the entry len to 0 for the hash/ahash walk, so > > > cyrpto_hash_walk_last will return the correct result indicating > > > that we have completed the scatter list walk. Otherwise we may > > > keep walking the sg list and access bogus memory address. > > > > > > Signed-off-by: Tim Chen > > > > Sorry but which driver is broken by this? > > > > I haven't tested other driver, but I see this problem when > I was testing the new multi-buffer sha1 driver OK, I'll add this patch along with the rest of your series then. I thought it affected existing drivers but it seems that it's only your driver that's affected. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt