All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers: rtc: remove dead drivers
Date: Tue, 05 Aug 2014 10:16:35 +0900	[thread overview]
Message-ID: <20140805101635.D576.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20140804173010.GS19374@bill-the-cat>

Hi Tom,


On Mon, 4 Aug 2014 13:30:10 -0400
Tom Rini <trini@ti.com> wrote:

> On Wed, Jul 30, 2014 at 07:20:03PM +0900, Masahiro Yamada wrote:
> 
> > The following configs are not defined at all:
> > 
> >  - CONFIG_RTC_DS1388
> >  - CONFIG_RTC_ISL1208
> >  - CONFIG_RTC_MX27
> >  - CONFIG_RTC_PL031
> >  - CONFIG_RTC_RS5C372A
> >  - CONFIG_SYS_DS1388_TCR_VAL
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> 
> I'm inclined to NAK this.  I can't speak to MX27 (Stefano?) but in other
> cases those RTCs can be breadboarded up on other EVMs or otherwise
> used in things that aren't quite upstream.  My long term hope is to be
> able to enable these drivers when building for am335x_evm or whatever,
> to get some coverage on them, and to also enable some other RTC drivers
> which have been posted but I put into RFC or Deferred in patchwork since
> they didn't have a board using them.


OK.

We will have to create config options in drivers/rtc/Kconfig
in our next migration step.
So, my intention was to drop unnecessary macros beforehand.
But I do not know which one is really unnecessary
and I simply grepped for undefined macros.

It is a good thing you reviewed this patch
and I retract it.


Best Regards
Masahiro Yamada

  reply	other threads:[~2014-08-05  1:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30 10:20 [U-Boot] [PATCH] drivers: rtc: remove dead drivers Masahiro Yamada
2014-08-04 17:30 ` Tom Rini
2014-08-05  1:16   ` Masahiro Yamada [this message]
2014-08-05  7:09   ` Stefano Babic
2014-08-06  2:34     ` Simon Glass
2014-08-06 11:01       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140805101635.D576.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.