From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XEczY-0001WD-Uz
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:33:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XEczS-0004nn-K1
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:33:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XEczS-0004nh-Dg
	for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:33:14 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75BXDIO023013
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 5 Aug 2014 07:33:13 -0400
Date: Tue, 5 Aug 2014 19:33:32 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140805113332.GB2705@T430.nay.redhat.com>
References: <1407229913-16862-1-git-send-email-famz@redhat.com>
	<1407229913-16862-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1407229913-16862-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to
 realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com

On Tue, 08/05 17:11, Fam Zheng wrote:
> Replace "init/destroy" with "realize/unrealize" in SCSIDeviceClass,
> which has errp as a parameter. So all the implementations now uses

s/uses/use/

> error_setg instead of error_report for reporting error.
> 
> Also in lsi53c895a, report the error when initializing the if=scsi
> devices, before dropping it, because the callee's error_report is
> changed to error_segs.

s/error_segs/error_setg/

Fam