From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Tue, 5 Aug 2014 23:03:24 +0200 Subject: [U-Boot] [linux-sunxi] Re: [PATCH] video: add cfb console driver for sunxi In-Reply-To: <20140804150500.GA13286@skynet.be> References: <1406996097-23167-1-git-send-email-libv@skynet.be> <53DF46B1.60107@redhat.com> <20140804150500.GA13286@skynet.be> Message-ID: <20140805210324.GF2019@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Aug 04, 2014 at 05:05:00PM +0200, Luc Verhaegen wrote: > On Mon, Aug 04, 2014 at 10:39:13AM +0200, Hans de Goede wrote: > > Hi Luc, > > > > First of all many thanks for your work on this. > > > > ATM I don't have time to do a full review, but I don't expect there > > to be too many suprises when I do find the time. > > > > Really my only concern is the handover of the reserved memory, etc. to > > the kernel. We need to get a plan in place for that *before* this can > > be merged. Note I don't want to raise any artificial barriers here, > > I would love to see this merged ASAP. But I don't want to paint us > > in a corner where u-boot having hdmi console support makes it harder > > to get kms support in the kernel going. I think we can both agree on that. > > > > So I really want to see some plan how this will work in place before merging. > > Note just a plan, I don't expect kernel patches ready to be merged for this, > > just a good idea / sketch of how all the bits will fit together. > > Memory is not the biggest worry. > > Some kernel code needs to claim clocks if the mode is to cleanly survive > the start of the kernel. If not, there is no coming back until a proper > display driver runs. If the simplefb driver claims these clocks, then > the simplefb driver also must release these clocks, and this driver > should then never be started again, so it should set the simplefb dt > node status to "disabled". I'm probably missing a bit of context, but one thing I still don't get is why you're taking into account the simplefb <-> KMS handover. It's a case that shouldn't exist. By essence, simplefb has never been meant for that. It's been meant to have a temporary solution until a full-fledged driver is merged in the kernel. Which is exactly the case we're into. But once the KMS driver gone, I'd just expect simplefb to go away. -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: