From: Dan Carpenter <dan.carpenter@oracle.com>
To: Benjamin Romer <benjamin.romer@unisys.com>
Cc: gregkh@linuxfoundation.org, sparmaintainer@unisys.com,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH 14/14] staging: unisys: fix macros in iochannel.h
Date: Wed, 6 Aug 2014 11:24:44 +0300 [thread overview]
Message-ID: <20140806082444.GX4856@mwanda> (raw)
In-Reply-To: <1407265078-21691-15-git-send-email-benjamin.romer@unisys.com>
On Tue, Aug 05, 2014 at 02:57:58PM -0400, Benjamin Romer wrote:
> Remove the do blocks around several macros and fix spacing and trailing
> semicolons.
>
do blocks are prefered style actually. Otherwise people start leaving
semi-colons out in the caller code.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2014-08-06 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 18:57 [PATCH 00/14] staging: unisys: common headers cleanup Benjamin Romer
2014-08-05 18:57 ` [PATCH 01/14] staging: unisys: get rid of unused VMMIO types Benjamin Romer
2014-08-05 18:57 ` [PATCH 02/14] staging: unisys: fix formatting in timskmod.h Benjamin Romer
2014-08-05 18:57 ` [PATCH 03/14] staging: unisys: get rid of semaphore macros Benjamin Romer
2014-08-05 18:57 ` [PATCH 04/14] staging: unisys: remove unused macros from timskmod.h Benjamin Romer
2014-08-05 18:57 ` [PATCH 05/14] staging: unisys: get rid of uiscmpxchg64 Benjamin Romer
2014-08-05 18:57 ` [PATCH 06/14] staging: unisys: fix whitespace in uisutils.h Benjamin Romer
2014-08-05 18:57 ` [PATCH 07/14] staging: unisys: fix line lengths in controlvmcompletionstatus.h Benjamin Romer
2014-08-05 18:57 ` [PATCH 08/14] staging: unisys: fix spacing in iovmcall_gnuc.h Benjamin Romer
2014-08-05 18:57 ` [PATCH 09/14] staging: unisys: clean up vmcall functions Benjamin Romer
2014-08-05 18:57 ` [PATCH 10/14] staging: unisys: fix spacing in vbusdeviceinfo.h Benjamin Romer
2014-08-05 18:57 ` [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h Benjamin Romer
2014-08-06 8:18 ` Dan Carpenter
2014-08-06 13:08 ` Romer, Benjamin M
2014-08-06 13:22 ` Dan Carpenter
2014-08-05 18:57 ` [PATCH 12/14] staging: unisys: fix spacing " Benjamin Romer
2014-08-05 18:57 ` [PATCH 13/14] staging: unisys: clean up comments in controlvmchannel.h message packet Benjamin Romer
2014-08-05 18:57 ` [PATCH 14/14] staging: unisys: fix macros in iochannel.h Benjamin Romer
2014-08-06 8:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806082444.GX4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=benjamin.romer@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.