All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Chen, Gong" <gong.chen@linux.intel.com>
Cc: bhelgaas@google.com, rdunlap@infradead.org, tony.luck@intel.com,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/5] RAS, trace: Update error definition format
Date: Wed, 6 Aug 2014 11:59:39 +0200	[thread overview]
Message-ID: <20140806095939.GB27033@pd.tnic> (raw)
In-Reply-To: <20140806090853.GA21650@gchen.bj.intel.com>

On Wed, Aug 06, 2014 at 05:08:54AM -0400, Chen, Gong wrote:
> Bjorn ever mentioned for this:
> "I'd like to see all those "BIT(...)" things changed to use the #defines
> that already exist in include/uapi/linux/pci_regs.h, e.g.,
> PCI_ERR_COR_RCVR.  That way grep will find these uses, which will make
> maintenance easier."

So explain that in the commit message but don't use some bits out of
context.

In general, when you read your own commit message, always ask yourself
whether other people will be able to understand it, long time from now
and out of context.

If yes, only then send out the patch.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2014-08-06  9:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  8:32 [PATCH 1/5] RAS, trace: Update error definition format Chen, Gong
2014-08-06  8:32 ` [PATCH 2/5] PCI-e, AER: Replenish missed AER status bits for AER driver Chen, Gong
2014-08-06  8:32 ` [PATCH 3/5] PCI-e, trace: Replenish missed AER status bits for PCIE trace I/F Chen, Gong
2014-08-06  8:32 ` [PATCH 4/5] PCI-e, AER: Make AER UC status naming clearer Chen, Gong
2014-08-06  8:32 ` [RFC PATCH 5/5] PCI, aer: Update initial value of UC error mask Chen, Gong
2014-08-06  9:32 ` [PATCH 1/5] RAS, trace: Update error definition format Borislav Petkov
2014-08-06  9:08   ` Chen, Gong
2014-08-06  9:59     ` Borislav Petkov [this message]
2014-08-07  0:59       ` Chen, Gong
2014-08-10 12:13 ` Chen, Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140806095939.GB27033@pd.tnic \
    --to=bp@alien8.de \
    --cc=bhelgaas@google.com \
    --cc=gong.chen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.