From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm: Remove drm_vblank_cleanup from drm_vblank_init error path. Date: Wed, 6 Aug 2014 13:51:51 +0300 Message-ID: <20140806105151.GR4193@intel.com> References: <1407288166-19881-1-git-send-email-mario.kleiner.de@gmail.com> <1407288166-19881-2-git-send-email-mario.kleiner.de@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D2E389F49 for ; Wed, 6 Aug 2014 03:51:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1407288166-19881-2-git-send-email-mario.kleiner.de@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mario Kleiner Cc: airlied@redhat.com, stable@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Aug 06, 2014 at 03:22:44AM +0200, Mario Kleiner wrote: > drm_vblank_cleanup() would operate on non-existent dev->vblank > data structure, as failure to allocate that data structure is > what triggers the error path in the first place. > = > Signed-off-by: Mario Kleiner > Cc: stable@vger.kernel.org Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > index 0de123a..553a58c 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -224,7 +224,7 @@ int drm_vblank_init(struct drm_device *dev, int num_c= rtcs) > return 0; > = > err: > - drm_vblank_cleanup(dev); > + dev->num_crtcs =3D 0; > return ret; > } > EXPORT_SYMBOL(drm_vblank_init); > -- = > 1.9.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC