All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-acpi@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pci@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joerg Roedel <joro@8bytes.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	xen-devel@lists.xenproject.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Yinghai Lu <yinghai@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Bugfix 0/2] Fix bugs caused by "use irqdomain to dynamically allocate IRQ for IOAPIC"
Date: Wed, 6 Aug 2014 10:28:23 -0400	[thread overview]
Message-ID: <20140806142823.GB13079__39346.0717205473$1407335490$gmane$org@laptop.dumpdata.com> (raw)
In-Reply-To: <53E20325.9020303@linux.intel.com>

On Wed, Aug 06, 2014 at 06:27:49PM +0800, Jiang Liu wrote:
> 
> 
> On 2014/8/6 1:58, Konrad Rzeszutek Wilk wrote:
> > On Wed, Aug 06, 2014 at 12:07:18AM +0800, Jiang Liu wrote:
> >>
> >>
> >> On 2014/8/5 21:04, Konrad Rzeszutek Wilk wrote:
> >>> On Tue, Aug 05, 2014 at 11:26:16AM +0800, Jiang Liu wrote:
> >>>> Two issues have been reported against patch set "use irqdomain to
> >>>> dynamically allocate IRQ for IOAPIC" at https://lkml.org/lkml/2014/6/9/44.
> >>>>
> >>>> This first one causes failure of suspend/hibernation, please refer to
> >>>> https://lkml.org/lkml/2014/7/28/822 for more information. And we have
> >>>> worked out a patch to fix it (https://lkml.org/lkml/2014/7/30/725) and
> >>>> Borislav has tested it. But with more testing and analysis, I found the
> >>>> provided patch still has some issues:
> >>>> 1) It may cause regression to Xen
> >>>
> >>> Could you elaborate please?
> >>>
> >>> Is there a git tree with all of these patches to test it?
> >> Hi Konrad,
> >> 	The patch at https://lkml.org/lkml/2014/7/30/725 skips invoking
> >> xen_pcifront_enable_irq() on resume from suspend or restore from
> >> hibernation. I'm not sure whether that will affect suspend/hibernation
> >> with Xen. This patch series won't affect Xen anymore.
> > 
> > Ah, it looks like:
> > 
> > 415         pcibios_enable_irq = xen_pcifront_enable_irq;                           
> > 416         pcibios_disable_irq = NULL;                                             
> > 
> > Is the culprit right? If there was an pcibios_disable_irq set, then said
> > patch would not been needed?
> > 
> > 
> >> 	I have prepared a tree for you at
> >> https://github.com/jiangliu/linux.git suspend
> > 
> > Thank you. Will give it a spin tomorrow.
> Hi Konrad,
> 	Thanks for review.
> 	I think no need to test it anymore. We are trying to fix an
> issue caused by IOAPIC related work. The previous version of patch
> is too coarse grain and may affect Xen. And now we have reworked it,
> so it shouldn't affect Xen anymore.

OK. Thanks for the heads up!
> Regards!
> Gerry
> 
> >>
> >> Thanks for help!
> >> Gerry
> >>
> >>>> 2) Flag dev->dev.power.is_prepared has already been cleared when
> >>>>    pcibios_enable_device() gets called, so it will cause IOAPIC pin
> >>>>    reference count leak.
> >>>>
> >>>> So I reworked the patch to fix above issues. The first patch fixes issue
> >>>> 1 by moving check of dev->dev.power.is_prepared pcibios_enable_irq, so
> >>>> it won't affect Xen. The second patch fixes the IOAPIC pin reference
> >>>> count leakage issue. It also solves the issue we have discussed at
> >>>> http://www.spinics.net/lists/linux-pci/msg32902.html
> >>>>
> >>>> Regards!
> >>>> Gerry
> >>>>
> >>>> Jiang Liu (2):
> >>>>   x86, irq, PCI: Keep IRQ assignment for PCI devices during
> >>>>     suspend/hibernation
> >>>>   x86, irq: Keep balance of IOAPIC pin reference count
> >>>>
> >>>>  arch/x86/pci/intel_mid_pci.c |    9 ++++++++-
> >>>>  arch/x86/pci/irq.c           |    8 +++++++-
> >>>>  drivers/acpi/pci_irq.c       |   15 +++++++++++++--
> >>>>  include/linux/pci.h          |    1 +
> >>>>  4 files changed, 29 insertions(+), 4 deletions(-)
> >>>>
> >>>> -- 
> >>>> 1.7.10.4
> >>>>

  reply	other threads:[~2014-08-06 14:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  3:26 [Bugfix 0/2] Fix bugs caused by "use irqdomain to dynamically allocate IRQ for IOAPIC" Jiang Liu
2014-08-05  3:26 ` [Bugfix 1/2] x86, irq, PCI: Keep IRQ assignment for PCI devices during suspend/hibernation Jiang Liu
2014-08-05 18:37   ` Borislav Petkov
2014-08-06 10:22     ` Jiang Liu
2014-08-06 17:09       ` Borislav Petkov
2014-08-07 11:03         ` tip/x86/apic (was: Re: [Bugfix 1/2] x86, irq, PCI: Keep IRQ assignment for PCI devices during suspend/hibernation) Borislav Petkov
2014-08-07 11:03           ` Borislav Petkov
2014-08-07 11:33           ` [GIT PULL] x86/apic changes for v3.17 Ingo Molnar
2014-08-07 13:31             ` Borislav Petkov
2014-08-07 16:08               ` Linus Torvalds
2014-08-07 16:08                 ` Linus Torvalds
2014-08-08  8:09                 ` Ingo Molnar
2014-08-08  8:09                   ` Ingo Molnar
2014-08-08  6:07             ` [Bugfix] x86, irq, PCI: Keep IRQ assignment for PCI devices during suspend/hibernation Jiang Liu
2014-08-08  9:19               ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-08-08 22:21             ` [GIT PULL] x86/apic changes for v3.17 David Rientjes
2014-08-09 17:06               ` Borislav Petkov
2014-08-11  5:27                 ` Jiang Liu
2014-08-05  3:26 ` [Bugfix 2/2] x86, irq: Keep balance of IOAPIC pin reference count Jiang Liu
2014-08-05 13:04 ` [Bugfix 0/2] Fix bugs caused by "use irqdomain to dynamically allocate IRQ for IOAPIC" Konrad Rzeszutek Wilk
2014-08-05 13:04 ` Konrad Rzeszutek Wilk
2014-08-05 16:07   ` Jiang Liu
2014-08-05 17:58     ` Konrad Rzeszutek Wilk
2014-08-06 10:27       ` Jiang Liu
2014-08-06 10:27       ` Jiang Liu
2014-08-06 14:28         ` Konrad Rzeszutek Wilk [this message]
2014-08-06 14:28         ` Konrad Rzeszutek Wilk
2014-08-05 17:58     ` Konrad Rzeszutek Wilk
2014-08-05 16:07   ` Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20140806142823.GB13079__39346.0717205473$1407335490$gmane$org@laptop.dumpdata.com' \
    --to=konrad.wilk@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.