From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbaHGTE7 (ORCPT ); Thu, 7 Aug 2014 15:04:59 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:52243 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbaHGTE5 (ORCPT ); Thu, 7 Aug 2014 15:04:57 -0400 Date: Thu, 07 Aug 2014 12:04:54 -0700 (PDT) Message-Id: <20140807.120454.1646328149054855088.davem@davemloft.net> To: paul@paul-moore.com Cc: geert@linux-m68k.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: sel_netif_init: 'err' is used uninitialized From: David Miller In-Reply-To: <5750080.46d2jsPKXX@sifl> References: <5750080.46d2jsPKXX@sifl> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Aug 2014 12:04:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s77J53nj019771 From: Paul Moore Date: Thu, 07 Aug 2014 10:26:14 -0400 > On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote: >> >> security/selinux/netif.c: In function sel_netif_init: >> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning: >> err is used uninitialized in this function >> >> Should it just return 0, like before? >> Or should it return the return value of register_netdevice_notifier() >> instead, which also returns an error code? Or is that failure non-critical? > > Hi, > > I posted a fix for this two days ago to the SELinux list (see below). As soon > as -rc1 is released and linux-next is back in business I'll be pushing the > patch to the SELinux #next branch. > > * http://marc.info/?l=selinux&m=140727033030054&w=2 With respect to this and the lack-of-inline warning fix we spoke about yesterday, why are you waiting and only pushing such bug fixes into your "next" branch? Those sort of things should be sent to Linus now to correct the errors introduced during the merge window, as I have done last night for all of the networking merge fallout. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: sel_netif_init: 'err' is used uninitialized Date: Thu, 07 Aug 2014 12:04:54 -0700 (PDT) Message-ID: <20140807.120454.1646328149054855088.davem@davemloft.net> References: <5750080.46d2jsPKXX@sifl> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 Content-Transfer-Encoding: base64 Cc: geert@linux-m68k.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: paul@paul-moore.com Return-path: In-Reply-To: <5750080.46d2jsPKXX@sifl> Sender: linux-security-module-owner@vger.kernel.org List-Id: netdev.vger.kernel.org RnJvbTogUGF1bCBNb29yZSA8cGF1bEBwYXVsLW1vb3JlLmNvbT4NCkRhdGU6IFRodSwgMDcgQXVn IDIwMTQgMTA6MjY6MTQgLTA0MDANCg0KPiBPbiBUaHVyc2RheSwgQXVndXN0IDA3LCAyMDE0IDEy OjMxOjE1IFBNIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToNCj4+IA0KPj4gc2VjdXJpdHkvc2Vs aW51eC9uZXRpZi5jOiBJbiBmdW5jdGlvbiChc2VsX25ldGlmX2luaXSiOg0KPj4gL3NjcmF0Y2gv Z2VlcnQvbGludXgvbGludXgtbTY4ay9zZWN1cml0eS9zZWxpbnV4L25ldGlmLmM6Mjg1OiB3YXJu aW5nOg0KPj4goWVycqIgaXMgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24NCj4+ IA0KPj4gU2hvdWxkIGl0IGp1c3QgcmV0dXJuIDAsIGxpa2UgYmVmb3JlPw0KPj4gT3Igc2hvdWxk IGl0IHJldHVybiB0aGUgcmV0dXJuIHZhbHVlIG9mIHJlZ2lzdGVyX25ldGRldmljZV9ub3RpZmll cigpDQo+PiBpbnN0ZWFkLCB3aGljaCBhbHNvIHJldHVybnMgYW4gZXJyb3IgY29kZT8gT3IgaXMg dGhhdCBmYWlsdXJlIG5vbi1jcml0aWNhbD8NCj4gDQo+IEhpLA0KPiANCj4gSSBwb3N0ZWQgYSBm aXggZm9yIHRoaXMgdHdvIGRheXMgYWdvIHRvIHRoZSBTRUxpbnV4IGxpc3QgKHNlZSBiZWxvdyku ICBBcyBzb29uIA0KPiBhcyAtcmMxIGlzIHJlbGVhc2VkIGFuZCBsaW51eC1uZXh0IGlzIGJhY2sg aW4gYnVzaW5lc3MgSSdsbCBiZSBwdXNoaW5nIHRoZSANCj4gcGF0Y2ggdG8gdGhlIFNFTGludXgg I25leHQgYnJhbmNoLg0KPiANCj4gICogaHR0cDovL21hcmMuaW5mby8/bD1zZWxpbnV4Jm09MTQw NzI3MDMzMDMwMDU0Jnc9Mg0KDQpXaXRoIHJlc3BlY3QgdG8gdGhpcyBhbmQgdGhlIGxhY2stb2Yt aW5saW5lIHdhcm5pbmcgZml4IHdlIHNwb2tlIGFib3V0DQp5ZXN0ZXJkYXksIHdoeSBhcmUgeW91 IHdhaXRpbmcgYW5kIG9ubHkgcHVzaGluZyBzdWNoIGJ1ZyBmaXhlcyBpbnRvIHlvdXINCiJuZXh0 IiBicmFuY2g/DQoNClRob3NlIHNvcnQgb2YgdGhpbmdzIHNob3VsZCBiZSBzZW50IHRvIExpbnVz IG5vdyB0byBjb3JyZWN0IHRoZSBlcnJvcnMNCmludHJvZHVjZWQgZHVyaW5nIHRoZSBtZXJnZSB3 aW5kb3csIGFzIEkgaGF2ZSBkb25lIGxhc3QgbmlnaHQgZm9yIGFsbA0Kb2YgdGhlIG5ldHdvcmtp bmcgbWVyZ2UgZmFsbG91dC4NCg==