All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: A Raghavendra Rao <raghav3276@gmail.com>
Cc: peter.p.waskiewicz.jr@intel.com, c@24.io,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	A Raghavendra Rao <arrao@cdac.in>
Subject: Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c
Date: Wed, 6 Aug 2014 22:35:30 -0700	[thread overview]
Message-ID: <20140807053530.GB5754@kroah.com> (raw)
In-Reply-To: <1407386447-16308-1-git-send-email-arrao@cdac.in>

On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote:
> Fix the following sparse warnings:
> drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom'
> was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol
> 'txqueue2outpipe' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning: symbol
> 'GetRxPacketShiftBytes819xUsb' was not declared. Should it be static?
> 
> Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c |   16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 7640386..6ad767a 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -667,12 +667,14 @@ static void tx_timeout(struct net_device *dev)
>  
>  
>  /* this is only for debug */
> -void dump_eprom(struct net_device *dev)
> +#ifdef DEBUG_EPROM

You can't define this, so just delete the whole thing.

Wait, didn't someone already do this?  Yes, someone just sent me this
same thing on the 1st, it's in my queue to apply after 3.17-rc1 is out.

Sorry, I can't take this.

greg k-h

  reply	other threads:[~2014-08-07  5:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07  4:40 [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c A Raghavendra Rao
2014-08-07  5:35 ` Greg KH [this message]
2014-08-07  6:02 ` Antoine Schweitzer-Chaput
  -- strict thread matches above, loose matches on Subject: below --
2014-08-06  8:44 [PATCH] staging: " A Raghavendra Rao
2014-08-07  3:08 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807053530.GB5754@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arrao@cdac.in \
    --cc=c@24.io \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=raghav3276@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.