On Mon, Jul 14, 2014 at 03:33:27PM +0100, Lee Jones wrote: [...] > +static int sti_pwm_probe(struct platform_device *pdev) > +{ [...] > + pc->clk = of_clk_get_by_name(np, "pwm"); This didn't compile because the np variable isn't declared. It was easy to fix up, so I did, but please be more careful next time that the patches you submit at least compile (preferably without sparse warnings of which I also fixed up a couple). Thierry